Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-31 19:15:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

chore: eslint prefer-arrow-callback

Browse Source
This commit is contained in:
Peter Jaszkowiak
2021-02-04 00:01:39 -07:00
committed by Julian Lam
parent 707b55b6a5
commit b56d9e12b5
334 changed files with 4995 additions and 5182 deletions
Download Patch File Download Diff File Expand all files Collapse all files

252
test/controllers-admin.js
View File

@@ -13,7 +13,7 @@ var groups = require('../src/groups');
var helpers = require('./helpers');
var meta = require('../src/meta');
describe('Admin Controllers', function () {
describe('Admin Controllers', () => {
var tid;
var cid;
var pid;
@@ -24,7 +24,7 @@ describe('Admin Controllers', function () {
var moderatorUid;
var jar;
before(function (done) {
before((done) => {
async.series({
category: function (next) {
categories.create({
@@ -44,7 +44,7 @@ describe('Admin Controllers', function () {
moderatorUid: function (next) {
user.create({ username: 'moderator', password: 'modmod' }, next);
},
}, async function (err, results) {
}, async (err, results) => {
if (err) {
return done(err);
}
@@ -65,11 +65,11 @@ describe('Admin Controllers', function () {
});
});
it('should 403 if user is not admin', function (done) {
helpers.loginUser('admin', 'barbar', function (err, _jar) {
it('should 403 if user is not admin', (done) => {
helpers.loginUser('admin', 'barbar', (err, _jar) => {
assert.ifError(err);
jar = _jar;
request(`${nconf.get('url')}/admin`, { jar: jar }, function (err, res, body) {
request(`${nconf.get('url')}/admin`, { jar: jar }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 403);
assert(body);
@@ -78,10 +78,10 @@ describe('Admin Controllers', function () {
});
});
it('should load admin dashboard', function (done) {
groups.join('administrators', adminUid, function (err) {
it('should load admin dashboard', (done) => {
groups.join('administrators', adminUid, (err) => {
assert.ifError(err);
request(`${nconf.get('url')}/admin`, { jar: jar }, function (err, res, body) {
request(`${nconf.get('url')}/admin`, { jar: jar }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -90,8 +90,8 @@ describe('Admin Controllers', function () {
});
});
it('should load groups page', function (done) {
request(`${nconf.get('url')}/admin/manage/groups`, { jar: jar }, function (err, res, body) {
it('should load groups page', (done) => {
request(`${nconf.get('url')}/admin/manage/groups`, { jar: jar }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -99,8 +99,8 @@ describe('Admin Controllers', function () {
});
});
it('should load groups detail page', function (done) {
request(`${nconf.get('url')}/admin/manage/groups/administrators`, { jar: jar }, function (err, res, body) {
it('should load groups detail page', (done) => {
request(`${nconf.get('url')}/admin/manage/groups/administrators`, { jar: jar }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -108,8 +108,8 @@ describe('Admin Controllers', function () {
});
});
it('should load global privileges page', function (done) {
request(`${nconf.get('url')}/admin/manage/privileges`, { jar: jar }, function (err, res, body) {
it('should load global privileges page', (done) => {
request(`${nconf.get('url')}/admin/manage/privileges`, { jar: jar }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -117,8 +117,8 @@ describe('Admin Controllers', function () {
});
});
it('should load privileges page for category 1', function (done) {
request(`${nconf.get('url')}/admin/manage/privileges/1`, { jar: jar }, function (err, res, body) {
it('should load privileges page for category 1', (done) => {
request(`${nconf.get('url')}/admin/manage/privileges/1`, { jar: jar }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -126,8 +126,8 @@ describe('Admin Controllers', function () {
});
});
it('should load manage uploads', function (done) {
request(`${nconf.get('url')}/admin/manage/uploads`, { jar: jar }, function (err, res, body) {
it('should load manage uploads', (done) => {
request(`${nconf.get('url')}/admin/manage/uploads`, { jar: jar }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -135,8 +135,8 @@ describe('Admin Controllers', function () {
});
});
it('should load general settings page', function (done) {
request(`${nconf.get('url')}/admin/settings`, { jar: jar }, function (err, res, body) {
it('should load general settings page', (done) => {
request(`${nconf.get('url')}/admin/settings`, { jar: jar }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -144,8 +144,8 @@ describe('Admin Controllers', function () {
});
});
it('should load email settings page', function (done) {
request(`${nconf.get('url')}/admin/settings/email`, { jar: jar }, function (err, res, body) {
it('should load email settings page', (done) => {
request(`${nconf.get('url')}/admin/settings/email`, { jar: jar }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -153,8 +153,8 @@ describe('Admin Controllers', function () {
});
});
it('should load user settings page', function (done) {
request(`${nconf.get('url')}/admin/settings/user`, { jar: jar }, function (err, res, body) {
it('should load user settings page', (done) => {
request(`${nconf.get('url')}/admin/settings/user`, { jar: jar }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -162,8 +162,8 @@ describe('Admin Controllers', function () {
});
});
it('should load info page for a user', function (done) {
request(`${nconf.get('url')}/api/user/regular/info`, { jar: jar, json: true }, function (err, res, body) {
it('should load info page for a user', (done) => {
request(`${nconf.get('url')}/api/user/regular/info`, { jar: jar, json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body.history);
@@ -174,16 +174,16 @@ describe('Admin Controllers', function () {
});
});
it('should 404 for edit/email page if user does not exist', function (done) {
request(`${nconf.get('url')}/api/user/doesnotexist/edit/email`, { jar: jar, json: true }, function (err, res) {
it('should 404 for edit/email page if user does not exist', (done) => {
request(`${nconf.get('url')}/api/user/doesnotexist/edit/email`, { jar: jar, json: true }, (err, res) => {
assert.ifError(err);
assert.equal(res.statusCode, 404);
done();
});
});
it('should load /admin/settings/homepage', function (done) {
request(`${nconf.get('url')}/api/admin/settings/homepage`, { jar: jar, json: true }, function (err, res, body) {
it('should load /admin/settings/homepage', (done) => {
request(`${nconf.get('url')}/api/admin/settings/homepage`, { jar: jar, json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body.routes);
@@ -191,8 +191,8 @@ describe('Admin Controllers', function () {
});
});
it('should load /admin/advanced/database', function (done) {
request(`${nconf.get('url')}/api/admin/advanced/database`, { jar: jar, json: true }, function (err, res, body) {
it('should load /admin/advanced/database', (done) => {
request(`${nconf.get('url')}/api/admin/advanced/database`, { jar: jar, json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
@@ -207,8 +207,8 @@ describe('Admin Controllers', function () {
});
});
it('should load /admin/extend/plugins', function (done) {
request(`${nconf.get('url')}/api/admin/extend/plugins`, { jar: jar, json: true }, function (err, res, body) {
it('should load /admin/extend/plugins', (done) => {
request(`${nconf.get('url')}/api/admin/extend/plugins`, { jar: jar, json: true }, (err, res, body) => {
assert.ifError(err);
assert(body.hasOwnProperty('installed'));
assert(body.hasOwnProperty('upgradeCount'));
@@ -218,8 +218,8 @@ describe('Admin Controllers', function () {
});
});
it('should load /admin/manage/users', function (done) {
request(`${nconf.get('url')}/api/admin/manage/users`, { jar: jar, json: true }, function (err, res, body) {
it('should load /admin/manage/users', (done) => {
request(`${nconf.get('url')}/api/admin/manage/users`, { jar: jar, json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -227,8 +227,8 @@ describe('Admin Controllers', function () {
});
});
it('should load /admin/manage/registration', function (done) {
request(`${nconf.get('url')}/api/admin/manage/registration`, { jar: jar, json: true }, function (err, res, body) {
it('should load /admin/manage/registration', (done) => {
request(`${nconf.get('url')}/api/admin/manage/registration`, { jar: jar, json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -236,8 +236,8 @@ describe('Admin Controllers', function () {
});
});
it('should 404 if users is not privileged', function (done) {
request(`${nconf.get('url')}/api/registration-queue`, { json: true }, function (err, res, body) {
it('should 404 if users is not privileged', (done) => {
request(`${nconf.get('url')}/api/registration-queue`, { json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 404);
assert(body);
@@ -245,8 +245,8 @@ describe('Admin Controllers', function () {
});
});
it('should load /api/registration-queue', function (done) {
request(`${nconf.get('url')}/api/registration-queue`, { jar: jar, json: true }, function (err, res, body) {
it('should load /api/registration-queue', (done) => {
request(`${nconf.get('url')}/api/registration-queue`, { jar: jar, json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -254,8 +254,8 @@ describe('Admin Controllers', function () {
});
});
it('should load /admin/manage/admins-mods', function (done) {
request(`${nconf.get('url')}/api/admin/manage/admins-mods`, { jar: jar, json: true }, function (err, res, body) {
it('should load /admin/manage/admins-mods', (done) => {
request(`${nconf.get('url')}/api/admin/manage/admins-mods`, { jar: jar, json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -263,17 +263,17 @@ describe('Admin Controllers', function () {
});
});
it('should load /admin/users/csv', function (done) {
it('should load /admin/users/csv', (done) => {
const socketAdmin = require('../src/socket.io/admin');
socketAdmin.user.exportUsersCSV({ uid: adminUid }, {}, function (err) {
socketAdmin.user.exportUsersCSV({ uid: adminUid }, {}, (err) => {
assert.ifError(err);
setTimeout(function () {
setTimeout(() => {
request(`${nconf.get('url')}/api/admin/users/csv`, {
jar: jar,
headers: {
referer: `${nconf.get('url')}/admin/manage/users`,
},
}, function (err, res, body) {
}, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -283,8 +283,8 @@ describe('Admin Controllers', function () {
});
});
it('should return 403 if no referer', function (done) {
request(`${nconf.get('url')}/api/admin/groups/administrators/csv`, { jar: jar }, function (err, res, body) {
it('should return 403 if no referer', (done) => {
request(`${nconf.get('url')}/api/admin/groups/administrators/csv`, { jar: jar }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 403);
assert.equal(body, '[[error:invalid-origin]]');
@@ -292,13 +292,13 @@ describe('Admin Controllers', function () {
});
});
it('should return 403 if referer is not /api/admin/groups/administrators/csv', function (done) {
it('should return 403 if referer is not /api/admin/groups/administrators/csv', (done) => {
request(`${nconf.get('url')}/api/admin/groups/administrators/csv`, {
jar: jar,
headers: {
referer: '/topic/1/test',
},
}, function (err, res, body) {
}, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 403);
assert.equal(body, '[[error:invalid-origin]]');
@@ -306,13 +306,13 @@ describe('Admin Controllers', function () {
});
});
it('should load /api/admin/groups/administrators/csv', function (done) {
it('should load /api/admin/groups/administrators/csv', (done) => {
request(`${nconf.get('url')}/api/admin/groups/administrators/csv`, {
jar: jar,
headers: {
referer: `${nconf.get('url')}/admin/manage/groups`,
},
}, function (err, res, body) {
}, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -320,8 +320,8 @@ describe('Admin Controllers', function () {
});
});
it('should load /admin/advanced/hooks', function (done) {
request(`${nconf.get('url')}/api/admin/advanced/hooks`, { jar: jar, json: true }, function (err, res, body) {
it('should load /admin/advanced/hooks', (done) => {
request(`${nconf.get('url')}/api/admin/advanced/hooks`, { jar: jar, json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -329,8 +329,8 @@ describe('Admin Controllers', function () {
});
});
it('should load /admin/advanced/cache', function (done) {
request(`${nconf.get('url')}/api/admin/advanced/cache`, { jar: jar, json: true }, function (err, res, body) {
it('should load /admin/advanced/cache', (done) => {
request(`${nconf.get('url')}/api/admin/advanced/cache`, { jar: jar, json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -338,8 +338,8 @@ describe('Admin Controllers', function () {
});
});
it('should load /admin/advanced/errors', function (done) {
request(`${nconf.get('url')}/api/admin/advanced/errors`, { jar: jar, json: true }, function (err, res, body) {
it('should load /admin/advanced/errors', (done) => {
request(`${nconf.get('url')}/api/admin/advanced/errors`, { jar: jar, json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -347,10 +347,10 @@ describe('Admin Controllers', function () {
});
});
it('should load /admin/advanced/errors/export', function (done) {
meta.errors.clear(function (err) {
it('should load /admin/advanced/errors/export', (done) => {
meta.errors.clear((err) => {
assert.ifError(err);
request(`${nconf.get('url')}/api/admin/advanced/errors/export`, { jar: jar }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/advanced/errors/export`, { jar: jar }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert.strictEqual(body, '');
@@ -359,11 +359,11 @@ describe('Admin Controllers', function () {
});
});
it('should load /admin/advanced/logs', function (done) {
it('should load /admin/advanced/logs', (done) => {
var fs = require('fs');
fs.appendFile(meta.logs.path, 'dummy log', function (err) {
fs.appendFile(meta.logs.path, 'dummy log', (err) => {
assert.ifError(err);
request(`${nconf.get('url')}/api/admin/advanced/logs`, { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/advanced/logs`, { jar: jar, json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -372,13 +372,13 @@ describe('Admin Controllers', function () {
});
});
it('should load /admin/settings/navigation', function (done) {
it('should load /admin/settings/navigation', (done) => {
var navigation = require('../src/navigation/admin');
var data = require('../install/data/navigation.json');
navigation.save(data, function (err) {
navigation.save(data, (err) => {
assert.ifError(err);
request(`${nconf.get('url')}/api/admin/settings/navigation`, { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/settings/navigation`, { jar: jar, json: true }, (err, res, body) => {
assert.ifError(err);
assert(body);
assert(body.available);
@@ -388,8 +388,8 @@ describe('Admin Controllers', function () {
});
});
it('should load /admin/development/info', function (done) {
request(`${nconf.get('url')}/api/admin/development/info`, { jar: jar, json: true }, function (err, res, body) {
it('should load /admin/development/info', (done) => {
request(`${nconf.get('url')}/api/admin/development/info`, { jar: jar, json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -397,8 +397,8 @@ describe('Admin Controllers', function () {
});
});
it('should load /admin/development/logger', function (done) {
request(`${nconf.get('url')}/api/admin/development/logger`, { jar: jar, json: true }, function (err, res, body) {
it('should load /admin/development/logger', (done) => {
request(`${nconf.get('url')}/api/admin/development/logger`, { jar: jar, json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -406,8 +406,8 @@ describe('Admin Controllers', function () {
});
});
it('should load /admin/advanced/events', function (done) {
request(`${nconf.get('url')}/api/admin/advanced/events`, { jar: jar, json: true }, function (err, res, body) {
it('should load /admin/advanced/events', (done) => {
request(`${nconf.get('url')}/api/admin/advanced/events`, { jar: jar, json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -415,8 +415,8 @@ describe('Admin Controllers', function () {
});
});
it('should load /admin/manage/categories', function (done) {
request(`${nconf.get('url')}/api/admin/manage/categories`, { jar: jar, json: true }, function (err, res, body) {
it('should load /admin/manage/categories', (done) => {
request(`${nconf.get('url')}/api/admin/manage/categories`, { jar: jar, json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -424,8 +424,8 @@ describe('Admin Controllers', function () {
});
});
it('should load /admin/manage/categories/1', function (done) {
request(`${nconf.get('url')}/api/admin/manage/categories/1`, { jar: jar, json: true }, function (err, res, body) {
it('should load /admin/manage/categories/1', (done) => {
request(`${nconf.get('url')}/api/admin/manage/categories/1`, { jar: jar, json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -433,8 +433,8 @@ describe('Admin Controllers', function () {
});
});
it('should load /admin/manage/categories/1/analytics', function (done) {
request(`${nconf.get('url')}/api/admin/manage/categories/1/analytics`, { jar: jar, json: true }, function (err, res, body) {
it('should load /admin/manage/categories/1/analytics', (done) => {
request(`${nconf.get('url')}/api/admin/manage/categories/1/analytics`, { jar: jar, json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -442,8 +442,8 @@ describe('Admin Controllers', function () {
});
});
it('should load /admin/extend/rewards', function (done) {
request(`${nconf.get('url')}/api/admin/extend/rewards`, { jar: jar, json: true }, function (err, res, body) {
it('should load /admin/extend/rewards', (done) => {
request(`${nconf.get('url')}/api/admin/extend/rewards`, { jar: jar, json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -451,8 +451,8 @@ describe('Admin Controllers', function () {
});
});
it('should load /admin/extend/widgets', function (done) {
request(`${nconf.get('url')}/api/admin/extend/widgets`, { jar: jar, json: true }, function (err, res, body) {
it('should load /admin/extend/widgets', (done) => {
request(`${nconf.get('url')}/api/admin/extend/widgets`, { jar: jar, json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -460,8 +460,8 @@ describe('Admin Controllers', function () {
});
});
it('should load /admin/settings/languages', function (done) {
request(`${nconf.get('url')}/api/admin/settings/languages`, { jar: jar, json: true }, function (err, res, body) {
it('should load /admin/settings/languages', (done) => {
request(`${nconf.get('url')}/api/admin/settings/languages`, { jar: jar, json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -469,16 +469,14 @@ describe('Admin Controllers', function () {
});
});
it('should load /admin/settings/social', function (done) {
it('should load /admin/settings/social', (done) => {
var socketAdmin = require('../src/socket.io/admin');
socketAdmin.social.savePostSharingNetworks({ uid: adminUid }, ['facebook', 'twitter'], function (err) {
socketAdmin.social.savePostSharingNetworks({ uid: adminUid }, ['facebook', 'twitter'], (err) => {
assert.ifError(err);
request(`${nconf.get('url')}/api/admin/settings/social`, { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/settings/social`, { jar: jar, json: true }, (err, res, body) => {
assert.ifError(err);
assert(body);
body = body.posts.map(function (network) {
return network && network.id;
});
body = body.posts.map(network => network && network.id);
assert(body.includes('facebook'));
assert(body.includes('twitter'));
done();
@@ -486,8 +484,8 @@ describe('Admin Controllers', function () {
});
});
it('should load /admin/manage/tags', function (done) {
request(`${nconf.get('url')}/api/admin/manage/tags`, { jar: jar, json: true }, function (err, res, body) {
it('should load /admin/manage/tags', (done) => {
request(`${nconf.get('url')}/api/admin/manage/tags`, { jar: jar, json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -495,8 +493,8 @@ describe('Admin Controllers', function () {
});
});
it('/post-queue should 404 for regular user', function (done) {
request(`${nconf.get('url')}/api/post-queue`, { json: true }, function (err, res, body) {
it('/post-queue should 404 for regular user', (done) => {
request(`${nconf.get('url')}/api/post-queue`, { json: true }, (err, res, body) => {
assert.ifError(err);
assert(body);
assert.equal(res.statusCode, 404);
@@ -504,8 +502,8 @@ describe('Admin Controllers', function () {
});
});
it('should load /post-queue', function (done) {
request(`${nconf.get('url')}/api/post-queue`, { jar: jar, json: true }, function (err, res, body) {
it('should load /post-queue', (done) => {
request(`${nconf.get('url')}/api/post-queue`, { jar: jar, json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -513,8 +511,8 @@ describe('Admin Controllers', function () {
});
});
it('/ip-blacklist should 404 for regular user', function (done) {
request(`${nconf.get('url')}/api/ip-blacklist`, { json: true }, function (err, res, body) {
it('/ip-blacklist should 404 for regular user', (done) => {
request(`${nconf.get('url')}/api/ip-blacklist`, { json: true }, (err, res, body) => {
assert.ifError(err);
assert(body);
assert.equal(res.statusCode, 404);
@@ -522,8 +520,8 @@ describe('Admin Controllers', function () {
});
});
it('should load /ip-blacklist', function (done) {
request(`${nconf.get('url')}/api/ip-blacklist`, { jar: jar, json: true }, function (err, res, body) {
it('should load /ip-blacklist', (done) => {
request(`${nconf.get('url')}/api/ip-blacklist`, { jar: jar, json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -531,8 +529,8 @@ describe('Admin Controllers', function () {
});
});
it('should load /admin/appearance/themes', function (done) {
request(`${nconf.get('url')}/api/admin/appearance/themes`, { jar: jar, json: true }, function (err, res, body) {
it('should load /admin/appearance/themes', (done) => {
request(`${nconf.get('url')}/api/admin/appearance/themes`, { jar: jar, json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -540,8 +538,8 @@ describe('Admin Controllers', function () {
});
});
it('should load /admin/appearance/customise', function (done) {
request(`${nconf.get('url')}/api/admin/appearance/customise`, { jar: jar, json: true }, function (err, res, body) {
it('should load /admin/appearance/customise', (done) => {
request(`${nconf.get('url')}/api/admin/appearance/customise`, { jar: jar, json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -549,9 +547,9 @@ describe('Admin Controllers', function () {
});
});
it('should load /recent in maintenance mode', function (done) {
it('should load /recent in maintenance mode', (done) => {
meta.config.maintenanceMode = 1;
request(`${nconf.get('url')}/api/recent`, { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/recent`, { jar: jar, json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -560,11 +558,11 @@ describe('Admin Controllers', function () {
});
});
describe('mods page', function () {
describe('mods page', () => {
var moderatorJar;
before(function (done) {
helpers.loginUser('moderator', 'modmod', function (err, _jar) {
before((done) => {
helpers.loginUser('moderator', 'modmod', (err, _jar) => {
assert.ifError(err);
moderatorJar = _jar;
@@ -572,16 +570,16 @@ describe('Admin Controllers', function () {
});
});
it('should error with no privileges', function (done) {
request(`${nconf.get('url')}/api/flags`, { json: true }, function (err, res, body) {
it('should error with no privileges', (done) => {
request(`${nconf.get('url')}/api/flags`, { json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(body.error, '[[error:no-privileges]]');
done();
});
});
it('should load flags page data', function (done) {
request(`${nconf.get('url')}/api/flags`, { jar: moderatorJar, json: true }, function (err, res, body) {
it('should load flags page data', (done) => {
request(`${nconf.get('url')}/api/flags`, { jar: moderatorJar, json: true }, (err, res, body) => {
assert.ifError(err);
assert(body);
assert(body.flags);
@@ -591,8 +589,8 @@ describe('Admin Controllers', function () {
});
});
it('should return invalid data if flag does not exist', function (done) {
request(`${nconf.get('url')}/api/flags/123123123`, { jar: moderatorJar, json: true }, function (err, res, body) {
it('should return invalid data if flag does not exist', (done) => {
request(`${nconf.get('url')}/api/flags/123123123`, { jar: moderatorJar, json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(body.error, '[[error:invalid-data]]');
done();
@@ -609,25 +607,25 @@ describe('Admin Controllers', function () {
}
});
it('should error with not enough reputation to flag', function (done) {
it('should error with not enough reputation to flag', (done) => {
var socketFlags = require('../src/socket.io/flags');
var oldValue = meta.config['min:rep:flag'];
meta.config['min:rep:flag'] = 1000;
socketFlags.create({ uid: regularUid }, { id: regularPid, type: 'post', reason: 'spam' }, function (err) {
socketFlags.create({ uid: regularUid }, { id: regularPid, type: 'post', reason: 'spam' }, (err) => {
assert.strictEqual(err.message, '[[error:not-enough-reputation-to-flag]]');
meta.config['min:rep:flag'] = oldValue;
done();
});
});
it('should return flag details', function (done) {
it('should return flag details', (done) => {
var socketFlags = require('../src/socket.io/flags');
var oldValue = meta.config['min:rep:flag'];
meta.config['min:rep:flag'] = 0;
socketFlags.create({ uid: regularUid }, { id: regularPid, type: 'post', reason: 'spam' }, function (err, flagId) {
socketFlags.create({ uid: regularUid }, { id: regularPid, type: 'post', reason: 'spam' }, (err, flagId) => {
meta.config['min:rep:flag'] = oldValue;
assert.ifError(err);
request(`${nconf.get('url')}/api/flags/${flagId}`, { jar: moderatorJar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/flags/${flagId}`, { jar: moderatorJar, json: true }, (err, res, body) => {
assert.ifError(err);
assert(body);
assert(body.reports);
@@ -639,7 +637,7 @@ describe('Admin Controllers', function () {
});
});
it('should escape special characters in config', function (done) {
it('should escape special characters in config', (done) => {
var plugins = require('../src/plugins');
function onConfigGet(config, callback) {
config.someValue = '"foo"';
@@ -648,14 +646,14 @@ describe('Admin Controllers', function () {
callback(null, config);
}
plugins.hooks.register('somePlugin', { hook: 'filter:config.get', method: onConfigGet });
request(`${nconf.get('url')}/admin`, { jar: jar }, function (err, res, body) {
request(`${nconf.get('url')}/admin`, { jar: jar }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
assert(body.includes('"someValue":"\\\\"foo\\\\""'));
assert(body.includes('"otherValue":"\\\'123\\\'"'));
assert(body.includes('"script":"<\\/script>"'));
request(nconf.get('url'), { jar: jar }, function (err, res, body) {
request(nconf.get('url'), { jar: jar }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);