Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat: support packageManager property in package.json

Browse Source 
resolves #10714
This commit is contained in:
Opliko
2022-06-19 16:32:19 +00:00
committed by Julian Lam
parent 13a17bd10a
commit b3a37a7f35
1 changed files with 20 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
src/cli/package-install.js
View File

@@ -61,6 +61,14 @@ pkgInstall.supportedPackageManager = [
pkgInstall.getPackageManager = () => {
try {
const packageContents = require(paths.currentPackage);
// This regex technically allows invalid values:
// cnpm isn't supported by corepack and it doesn't enforce a version string being present
const pmRegex = new RegExp(`^(?<packageManager>${pkgInstall.supportedPackageManager.join('|')})@?[\\d\\w\\.\\-]*$`);
const packageManager = packageContents.packageManager ? packageContents.packageManager.match(pmRegex) : false;
if (packageManager) {
return packageManager.groups.packageManager;
}
fs.accessSync(path.join(paths.nodeModules, 'nconf/package.json'), fs.constants.R_OK);
const nconf = require('nconf');
if (!Object.keys(nconf.stores).length) {
@@ -70,42 +78,30 @@ pkgInstall.getPackageManager = () => {
file: configFile,
});
}
if (nconf.get('package_manager') && !pkgInstall.supportedPackageManager.includes(nconf.get('package_manager'))) {
nconf.clear('package_manager');
}
if (!nconf.get('package_manager')) {
// Best guess based on lockfile detection
try {
// use npm if lockfile present
fs.accessSync(path.resolve(__dirname, '../../package-lock.json'), fs.constants.R_OK);
} catch (e) {
nconf.set('package_manager', [
// no cnpm detection as it uses same lockfile as npm
'yarn.lock', 'pnpm-lock.yaml',
].reduce((result, cur) => {
if (result) {
return result;
}
try {
fs.accessSync(path.resolve(__dirname, `../../${cur}`), fs.constants.R_OK);
return cur.slice(0, 4);
} catch (e) {
return result;
}
}, undefined));
}
nconf.set('package_manager', getPackageManagerByLockfile());
}
return nconf.get('package_manager') || 'npm';
} catch (e) {
// nconf not install or other unexpected error/exception
return 'npm';
// nconf not installed or other unexpected error/exception
return getPackageManagerByLockfile() || 'npm';
}
};
function getPackageManagerByLockfile() {
for (const [packageManager, lockfile] of Object.entries({ npm: 'package-lock.json', yarn: 'yarn.lock', pnpm: 'pnpm-lock.yaml' })) {
try {
fs.accessSync(path.resolve(__dirname, `../../${lockfile}`), fs.constants.R_OK);
return packageManager;
} catch (e) {}
}
}
pkgInstall.installAll = () => {
const prod = process.env.NODE_ENV !== 'development';
let command = 'npm install';