Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-01-01 13:20:41 +01:00
Code Issues Packages Projects Releases Wiki Activity

breaking: remove deprecated socket.emit('admin.categories.create')

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2021-12-06 20:14:44 -05:00
parent 10c19af2ad
commit b335372348
3 changed files with 4 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/privileges/admin.js
View File

@@ -76,7 +76,6 @@ privsAdmin.socketMap = {
'admin.rooms.getAll': 'admin:dashboard',
'admin.analytics.get': 'admin:dashboard',
'admin.categories.create': 'admin:categories',
'admin.categories.update': 'admin:categories',
'admin.categories.purge': 'admin:categories',
'admin.categories.copySettingsFrom': 'admin:categories',

9
src/socket.io/admin/categories.js
View File

@@ -7,15 +7,6 @@ const sockets = require('..');
const Categories = module.exports;
Categories.create = async function (socket, data) {
sockets.warnDeprecated(socket, 'POST /api/v3/categories');
if (!data) {
throw new Error('[[error:invalid-data]]');
}
return await api.categories.create(socket, data);
};
Categories.getNames = async function () {
return await categories.getAllCategoryFields(['cid', 'name']);
};

11
test/categories.js
View File

@@ -350,20 +350,17 @@ describe('Categories', () => {
describe('admin socket methods', () => {
const socketCategories = require('../src/socket.io/admin/categories');
const apiCategories = require('../src/api/categories');
let cid;
before((done) => {
socketCategories.create({ uid: adminUid }, {
before(async () => {
const category = await apiCategories.create({ uid: adminUid }, {
name: 'update name',
description: 'update description',
parentCid: categoryObj.cid,
icon: 'fa-check',
order: '5',
}, (err, category) => {
assert.ifError(err);
cid = category.cid;
done();
});
cid = category.cid;
});
it('should return error with invalid data', (done) => {