Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 08:36:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: shorter code

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2020-06-19 12:03:33 -04:00
parent d1c1cb2cc1
commit af790e3f5e
3 changed files with 3 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/groups/data.js
View File

@@ -25,13 +25,8 @@ module.exports = function (Groups) {
return memo; return memo;
}, []); }, []);
let groupData;
const keys = groupNames.map(groupName => 'group:' + groupName); const keys = groupNames.map(groupName => 'group:' + groupName);
if (fields.length) { const groupData = await (fields.length ? db.getObjectsFields(keys, fields) : db.getObjects(keys));
groupData = await db.getObjectsFields(keys, fields);
} else {
groupData = await db.getObjects(keys);
}
if (ephemeralIdx.length) { if (ephemeralIdx.length) {
ephemeralIdx.forEach(function (idx) { ephemeralIdx.forEach(function (idx) {
groupData[idx] = Groups.getEphemeralGroup(groupNames[idx]); groupData[idx] = Groups.getEphemeralGroup(groupNames[idx]);

8
src/messaging/data.js
View File

@@ -18,13 +18,7 @@ module.exports = function (Messaging) {
} }
const keys = mids.map(mid => 'message:' + mid); const keys = mids.map(mid => 'message:' + mid);
let messages; const messages = await (fields.length ? db.getObjectsFields(keys, fields) : db.getObjects(keys));
if (fields.length) {
messages = await db.getObjectsFields(keys, fields);
} else {
messages = await db.getObjects(keys);
}
messages.forEach(message => modifyMessage(message, fields)); messages.forEach(message => modifyMessage(message, fields));
return messages; return messages;
}; };

7
src/posts/data.js
View File

@@ -15,12 +15,7 @@ module.exports = function (Posts) {
return []; return [];
} }
const keys = pids.map(pid => 'post:' + pid); const keys = pids.map(pid => 'post:' + pid);
let postData; const postData = await (fields.length ? db.getObjectsFields(keys, fields) : db.getObjects(keys));
if (fields.length) {
postData = await db.getObjectsFields(keys, fields);
} else {
postData = await db.getObjects(keys);
}
const result = await plugins.fireHook('filter:post.getFields', { const result = await plugins.fireHook('filter:post.getFields', {
pids: pids, pids: pids,
posts: postData, posts: postData,