Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: browser title if options.title is undefined

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2023-05-16 13:05:03 -04:00
parent 826cc51410
commit adf14ea57c
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/controllers/helpers.js
View File

@@ -238,10 +238,11 @@ helpers.buildBreadcrumbs = function (crumbs) {
}; };
helpers.buildTitle = function (pageTitle) { helpers.buildTitle = function (pageTitle) {
const titleLayout = meta.config.titleLayout || '{pageTitle} | {browserTitle}'; pageTitle = pageTitle || '';
const titleLayout = meta.config.titleLayout || `${pageTitle ? '{pageTitle} | ' : ''}{browserTitle}`;
const browserTitle = validator.escape(String(meta.config.browserTitle || meta.config.title || 'NodeBB')); const browserTitle = validator.escape(String(meta.config.browserTitle || meta.config.title || 'NodeBB'));
pageTitle = pageTitle || '';
const title = titleLayout.replace('{pageTitle}', () => pageTitle).replace('{browserTitle}', () => browserTitle); const title = titleLayout.replace('{pageTitle}', () => pageTitle).replace('{browserTitle}', () => browserTitle);
return title; return title;
}; };

2
src/middleware/render.js
View File

@@ -162,7 +162,7 @@ module.exports = function (middleware) {
templateValues.configJSON = jsesc(JSON.stringify(res.locals.config), { isScriptContext: true }); templateValues.configJSON = jsesc(JSON.stringify(res.locals.config), { isScriptContext: true });
const title = translator.unescape(utils.stripHTMLTags(options.title)); const title = translator.unescape(utils.stripHTMLTags(options.title || ''));
const results = await utils.promiseParallel({ const results = await utils.promiseParallel({
isAdmin: user.isAdministrator(req.uid), isAdmin: user.isAdministrator(req.uid),
isGlobalMod: user.isGlobalModerator(req.uid), isGlobalMod: user.isGlobalModerator(req.uid),