Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: don't crash on activitypub.send non-2xx, better logging for successful sends

Browse Source
This commit is contained in:
Julian Lam
2024-02-08 21:34:26 -05:00
parent 874b24cbcf
commit ac56289fa2
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/activitypub/index.js
View File

@@ -223,7 +223,7 @@ ActivityPub.send = async (type, id, targets, payload) => {
const keyData = await ActivityPub.getPrivateKey(type, id); const keyData = await ActivityPub.getPrivateKey(type, id);
const headers = await ActivityPub.sign(keyData, uri, payload); const headers = await ActivityPub.sign(keyData, uri, payload);
winston.verbose(`[activitypub/send] ${uri}`); winston.verbose(`[activitypub/send] ${uri}`);
const { response } = await request.post(uri, { const { response, body } = await request.post(uri, {
headers: { headers: {
...headers, ...headers,
'content-type': 'application/ld+json; profile="https://www.w3.org/ns/activitystreams"', 'content-type': 'application/ld+json; profile="https://www.w3.org/ns/activitystreams"',
@@ -231,9 +231,10 @@ ActivityPub.send = async (type, id, targets, payload) => {
body: payload, body: payload,
}); });
if (!String(response.statusCode).startsWith('2')) { if (String(response.statusCode).startsWith('2')) {
// todo: i18n this winston.verbose(`[activitypub/send] Successfully sent ${payload.type} to ${uri}`);
throw new Error('activity-failed'); } else {
winston.warn(`[activitypub/send] Could not send ${payload.type} to ${uri}; error: ${body}`);
} }
})); }));
}; };