Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-03 12:36:02 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: api module returns promise, error-first cb if cb passed in

Browse Source 
no more separate onSuccess onError callbacks

/cc @baris
This commit is contained in:
Julian Lam
2020-10-14 10:02:02 -04:00
parent d52992de1b
commit a784d10fff
16 changed files with 103 additions and 133 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
public/src/modules/api.js
View File

@@ -4,24 +4,33 @@ define('api', () => {
const api = {};
const baseUrl = config.relative_path + '/api/v3';
function call(options, onSuccess, onError) {
$.ajax(Object.assign({
headers: {
'x-csrf-token': config.csrf_token,
},
}, options))
.done((res) => {
if (onSuccess) {
onSuccess(res.response);
}
})
.fail((ev) => {
if (onError === 'default') {
app.alertError(ev.responseJSON.status.message);
} else if (onError) {
onError(ev.responseJSON);
}
});
function call(options, callback) {
return new Promise((resolve, reject) => {
$.ajax(Object.assign({
headers: {
'x-csrf-token': config.csrf_token,
},
}, options))
.done((res) => {
resolve(res.response);
if (callback) {
callback(undefined, res.response);
}
})
.fail((ev) => {
const error = new Error(ev.responseJSON.status.message);
reject(error);
if (!utils.hasLanguageKey(ev.responseJSON.status.message)) {
app.alertError(ev.responseJSON.status.message);
}
if (callback) {
callback(error);
}
});
});
}
api.get = (route, payload, onSuccess, onError) => call({