Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-10 07:55:46 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: return proper API-style response if exception caught by error handler on v3 routes [breaking]

Browse Source
This commit is contained in:
Julian Lam
2021-07-09 10:30:46 -04:00
parent ae14016efc
commit a54a3ee1ca
2 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/middleware/user.js
View File

@@ -65,7 +65,7 @@ module.exports = function (middleware) {
return true;
}
throw new Error('A master token was received without a corresponding `_uid` in the request body');
throw new Error('[[errors:api.master-token-no-uid]]');
} else {
winston.warn('[api/authenticate] Unable to find user after verifying token');
return true;
@@ -84,6 +84,7 @@ module.exports = function (middleware) {
return !res.headersSent;
}
// TODO: Remove in v1.18.0
middleware.authenticate = helpers.try(async (req, res, next) => {
winston.warn(`[middleware] middleware.authenticate has been deprecated, page and API routes are now automatically authenticated via setup(Page|API)Route. Use middleware.authenticateRequest (if not using route helper) and middleware.ensureLoggedIn instead. (request path: ${req.path})`);
if (!await authenticate(req, res)) {