Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat: sort dependencies alphabetically

Browse Source 
... when merging from install/package.json

/cc @pitaj
This commit is contained in:
Julian Lam
2020-08-25 11:06:41 -04:00
parent 6c4aed8cf4
commit a4dbbc3749
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/cli/package-install.js
View File

@@ -23,14 +23,20 @@ function updatePackageFile() {
const defaultPackageContents = JSON.parse(fs.readFileSync(packageDefaultFilePath, 'utf8')); const defaultPackageContents = JSON.parse(fs.readFileSync(packageDefaultFilePath, 'utf8'));
const dependencies = {}; let dependencies = {};
Object.entries(oldPackageContents.dependencies || {}).forEach(([dep, version]) => { Object.entries(oldPackageContents.dependencies || {}).forEach(([dep, version]) => {
if (isPackage.test(dep)) { if (isPackage.test(dep)) {
dependencies[dep] = version; dependencies[dep] = version;
} }
}); });
const packageContents = { ...oldPackageContents, ...defaultPackageContents, dependencies: { ...dependencies, ...defaultPackageContents.dependencies } }; // Sort dependencies alphabetically
dependencies = Object.entries({ ...dependencies, ...defaultPackageContents.dependencies }).sort((a, b) => (a < b ? -1 : 1)).reduce((memo, pkg) => {
memo[pkg[0]] = pkg[1];
return memo;
}, {});
const packageContents = { ...oldPackageContents, ...defaultPackageContents, dependencies: dependencies };
fs.writeFileSync(packageFilePath, JSON.stringify(packageContents, null, 2)); fs.writeFileSync(packageFilePath, JSON.stringify(packageContents, null, 2));
} }