Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-27 17:16:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove dupe code

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2019-09-09 19:34:20 -04:00
parent e93ef0d7fd
commit a4d84a66dd
1 changed files with 24 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

55
src/socket.io/posts/tools.js
View File

@@ -55,72 +55,65 @@ module.exports = function (SocketPosts) {
}; };
SocketPosts.delete = async function (socket, data) { SocketPosts.delete = async function (socket, data) {
if (!data || !data.pid) { await deleteOrRestore(socket, data, {
throw new Error('[[error:invalid-data]]'); command: 'delete',
} event: 'event:post_deleted',
const postData = await posts.tools.delete(socket.uid, data.pid);
const results = await isMainAndLastPost(data.pid);
if (results.isMain && results.isLast) {
await deleteOrRestoreTopicOf('delete', data.pid, socket);
}
websockets.in('topic_' + data.tid).emit('event:post_deleted', postData);
await events.log({
type: 'post-delete', type: 'post-delete',
uid: socket.uid,
pid: data.pid,
tid: postData.tid,
ip: socket.ip,
}); });
}; };
SocketPosts.restore = async function (socket, data) { SocketPosts.restore = async function (socket, data) {
await deleteOrRestore(socket, data, {
command: 'restore',
event: 'event:post_restored',
type: 'post-restore',
});
};
async function deleteOrRestore(socket, data, params) {
if (!data || !data.pid) { if (!data || !data.pid) {
throw new Error('[[error:invalid-data]]'); throw new Error('[[error:invalid-data]]');
} }
const postData = await posts.tools.restore(socket.uid, data.pid); const postData = await posts.tools[params.command](socket.uid, data.pid);
const results = await isMainAndLastPost(data.pid); const results = await isMainAndLastPost(data.pid);
if (results.isMain && results.isLast) { if (results.isMain && results.isLast) {
await deleteOrRestoreTopicOf('restore', data.pid, socket); await deleteOrRestoreTopicOf(params.command, data.pid, socket);
} }
websockets.in('topic_' + data.tid).emit('event:post_restored', postData);
websockets.in('topic_' + data.tid).emit(params.event, postData);
await events.log({ await events.log({
type: 'post-restore', type: params.type,
uid: socket.uid, uid: socket.uid,
pid: data.pid, pid: data.pid,
tid: postData.tid, tid: postData.tid,
ip: socket.ip, ip: socket.ip,
}); });
}; }
SocketPosts.deletePosts = async function (socket, data) { SocketPosts.deletePosts = async function (socket, data) {
if (!data || !Array.isArray(data.pids)) { await deletePurgePosts(socket, data, 'delete');
throw new Error('[[error:invalid-data]]');
}
for (const pid of data.pids) {
/* eslint-disable no-await-in-loop */
await SocketPosts.delete(socket, { pid: pid, tid: data.tid });
}
}; };
SocketPosts.purgePosts = async function (socket, data) { SocketPosts.purgePosts = async function (socket, data) {
await deletePurgePosts(socket, data, 'purge');
};
async function deletePurgePosts(socket, data, command) {
if (!data || !Array.isArray(data.pids)) { if (!data || !Array.isArray(data.pids)) {
throw new Error('[[error:invalid-data]]'); throw new Error('[[error:invalid-data]]');
} }
for (const pid of data.pids) { for (const pid of data.pids) {
/* eslint-disable no-await-in-loop */ /* eslint-disable no-await-in-loop */
await SocketPosts.purge(socket, { pid: pid, tid: data.tid }); await SocketPosts[command](socket, { pid: pid, tid: data.tid });
} }
}; }
SocketPosts.purge = async function (socket, data) { SocketPosts.purge = async function (socket, data) {
if (!data || !parseInt(data.pid, 10)) { if (!data || !parseInt(data.pid, 10)) {
throw new Error('[[error:invalid-data]]'); throw new Error('[[error:invalid-data]]');
} }
const results = await isMainAndLastPost(data.pid); const results = await isMainAndLastPost(data.pid);
if (results.isMain && !results.isLast) { if (results.isMain && !results.isLast) {
throw new Error('[[error:cant-purge-main-post]]'); throw new Error('[[error:cant-purge-main-post]]');