From a3cadff1d3652893bf4232a01e739de6a10a2d4c Mon Sep 17 00:00:00 2001 From: Julian Lam Date: Tue, 27 Jan 2015 14:47:39 -0500 Subject: [PATCH] updated settings module (v2) to fix multiple selects and checkboxes using name instead of id, which isn't always guaranteed to be set. --- public/src/modules/settings.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/public/src/modules/settings.js b/public/src/modules/settings.js index 66b76fc4fd..8c7d74a448 100644 --- a/public/src/modules/settings.js +++ b/public/src/modules/settings.js @@ -482,14 +482,14 @@ define('settings', function () { formEl.find('input[type="checkbox"]').each(function (idx, inputEl) { inputEl = $(inputEl); if (!inputEl.is(':checked')) { - values[inputEl.attr('id')] = 'off'; + values[inputEl.attr('name')] = 'off'; } }); // Normalizing value of multiple selects formEl.find('select[multiple]').each(function(idx, selectEl) { selectEl = $(selectEl); - values[selectEl.attr('id')] = JSON.stringify(selectEl.val()); + values[selectEl.attr('name')] = JSON.stringify(selectEl.val()); }); socket.emit('admin.settings.set', {