Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-27 00:56:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: use fs.promises

Browse Source
This commit is contained in:
Julian Lam
2022-02-04 13:24:57 -05:00
parent 845717b8c0
commit a0a3870611
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
test/package-install.js
View File

@@ -2,12 +2,12 @@
const { execSync } = require('child_process'); const { execSync } = require('child_process');
const path = require('path'); const path = require('path');
const { readFileSync } = require('fs'); const { readFile } = require('fs').promises;
const assert = require('assert'); const assert = require('assert');
describe('Package install', () => { describe('Package install', () => {
it('should remove non-`nodebb-` modules not specified in `install/package.json`', () => { it('should remove non-`nodebb-` modules not specified in `install/package.json`', async () => {
const oldValue = process.env.NODE_ENV; const oldValue = process.env.NODE_ENV;
process.env.NODE_ENV = 'development'; process.env.NODE_ENV = 'development';
const packageFilePath = path.join(__dirname, '../package.json'); const packageFilePath = path.join(__dirname, '../package.json');
@@ -18,15 +18,17 @@ describe('Package install', () => {
execSync('npm install dotenv --save'); execSync('npm install dotenv --save');
// assert it saves in package.json // assert it saves in package.json
const packageWithExtras = JSON.parse(readFileSync(packageFilePath, 'utf8')); const packageWithExtras = JSON.parse(await readFile(packageFilePath, 'utf8'));
assert(packageWithExtras.dependencies.dotenv, 'dependency did not save'); assert(packageWithExtras.dependencies.dotenv, 'dependency did not save');
// update the package file // update the package file
require('../src/cli/package-install').updatePackageFile(); require('../src/cli/package-install').updatePackageFile();
// assert it removed the extra package // assert it removed the extra package
const packageCleaned = JSON.parse(readFileSync(packageFilePath, 'utf8')); const packageCleaned = JSON.parse(await readFile(packageFilePath, 'utf8'));
assert(!packageCleaned.dependencies.dotenv, 'dependency was not removed'); assert(!packageCleaned.dependencies.dotenv, 'dependency was not removed');
process.env.NODE_ENV = oldValue; process.env.NODE_ENV = oldValue;
}); });
// it('should ')
}); });