Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 08:36:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: send hard 404 instead of soft 404 for missing modules

Browse Source 
We used to send a soft 404 because require.js would error out on
a 404, but it seems years ago, error handling was added to the
require() call, so a hard 404 will not throw errors to the console
This commit is contained in:
Julian Lam
2020-08-07 11:30:47 -04:00
parent 8032c8bdfe
commit 9f3b78118a
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/controllers/404.js
View File

@@ -21,7 +21,7 @@ exports.handle404 = function handle404(req, res) {
}
if (isClientScript.test(req.url)) {
res.type('text/javascript').status(200).send('');
res.type('text/javascript').status(404).send('Not Found');
} else if (req.path.startsWith(relativePath + '/assets/uploads') || (req.get('accept') && !req.get('accept').includes('text/html')) || req.path === '/favicon.ico') {
meta.errors.log404(req.path || '');
res.sendStatus(404);