fixing issue where navigating to a non-existant category_id caused NodeBB

to crash
This commit is contained in:
Julian Lam
2013-07-22 20:29:51 -04:00
parent 741a5843a1
commit 9e7afcf0ab
4 changed files with 22 additions and 18 deletions

View File

@@ -209,11 +209,8 @@ var express = require('express'),
}
var category_url = cid + (req.params.slug ? '/' + req.params.slug : '');
categories.getCategoryById(cid, 0, function(returnData) {
if(!returnData) {
res.redirect('404');
return;
}
categories.getCategoryById(cid, 0, function(err, returnData) {
if(err) return res.redirect('404');
res.send(
app.build_header(res) +
@@ -379,8 +376,9 @@ var express = require('express'),
});
break;
case 'category' :
categories.getCategoryById(req.params.id, uid, function(data) {
res.json(data);
categories.getCategoryById(req.params.id, uid, function(err, data) {
if (!err) res.json(data);
else res.send(404);
}, req.params.id, uid);
break;
case 'recent' :