Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-29 10:06:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

Revert "feat: #8493, plugin helper for standardised link/button injection"

Browse Source 
This reverts commit 0bbb813e4b.
This commit is contained in:
Julian Lam
2020-08-07 12:25:17 -04:00
parent 0bbb813e4b
commit 9e3fd0e479
3 changed files with 83 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/controllers/helpers.js
View File

@@ -1,6 +1,5 @@
'use strict';
const winston = require('winston');
const nconf = require('nconf');
const validator = require('validator');
const querystring = require('querystring');
@@ -219,34 +218,6 @@ helpers.buildTitle = function (pageTitle) {
return title;
};
helpers.buildLinks = async function (event, links, states) {
const filtered = await plugins.fireHook(`filter:buildLinks.${event}`, { links, states });
return filtered.links.filter(function (link, index) {
// "public" is the old property, if visibility is defined, discard `public`
if (link.hasOwnProperty('public') && !link.hasOwnProperty('visibility')) {
winston.warn('[account/profileMenu (' + link.id + ')] Use of the `.public` property is deprecated, use `visibility` now');
return link && (link.public || filtered.states.self);
}
// Default visibility
link.visibility = { self: true,
other: true,
moderator: true,
globalMod: true,
admin: true,
canViewInfo: true,
...link.visibility };
var permit = Object.keys(filtered.states).some(function (state) {
return filtered.states[state] && link.visibility[state];
});
filtered.links[index].public = permit;
return permit;
});
};
helpers.getCategories = async function (set, uid, privilege, selectedCid) {
const cids = await categories.getCidsByPrivilege(set, uid, privilege);
return await getCategoryData(cids, uid, selectedCid);