mirror of
				https://github.com/NodeBB/NodeBB.git
				synced 2025-10-30 18:46:01 +01:00 
			
		
		
		
	fix: #9450 express session saved even if saveUninitialized explicitly passed in
This commit is contained in:
		| @@ -11,6 +11,7 @@ const privileges = require('../privileges'); | ||||
| const plugins = require('../plugins'); | ||||
| const helpers = require('./helpers'); | ||||
| const auth = require('../routes/authentication'); | ||||
| const writeRouter = require('../routes/write'); | ||||
|  | ||||
| const controllers = { | ||||
| 	helpers: require('../controllers/helpers'), | ||||
| @@ -19,11 +20,12 @@ const controllers = { | ||||
|  | ||||
| const passportAuthenticateAsync = function (req, res) { | ||||
| 	return new Promise((resolve, reject) => { | ||||
| 		passport.authenticate('core.api', { session: false }, (err, user) => { | ||||
| 		passport.authenticate('core.api', (err, user) => { | ||||
| 			if (err) { | ||||
| 				reject(err); | ||||
| 			} else { | ||||
| 				resolve(user); | ||||
| 				res.on('finish', writeRouter.cleanup.bind(null, req)); | ||||
| 			} | ||||
| 		})(req, res); | ||||
| 	}); | ||||
|   | ||||
| @@ -63,3 +63,7 @@ Write.reload = async (params) => { | ||||
| 		helpers.formatApiResponse(404, res); | ||||
| 	}); | ||||
| }; | ||||
|  | ||||
| Write.cleanup = (req) => { | ||||
| 	req.session.destroy(); | ||||
| }; | ||||
|   | ||||
		Reference in New Issue
	
	Block a user