Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: #9450 express session saved even if saveUninitialized explicitly passed in

Browse Source
This commit is contained in:
Julian Lam
2021-04-02 10:40:48 -04:00
parent 7754c1f66e
commit 9c52fd2e74
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/middleware/user.js
View File

@@ -11,6 +11,7 @@ const privileges = require('../privileges');
const plugins = require('../plugins'); const plugins = require('../plugins');
const helpers = require('./helpers'); const helpers = require('./helpers');
const auth = require('../routes/authentication'); const auth = require('../routes/authentication');
const writeRouter = require('../routes/write');
const controllers = { const controllers = {
helpers: require('../controllers/helpers'), helpers: require('../controllers/helpers'),
@@ -19,11 +20,12 @@ const controllers = {
const passportAuthenticateAsync = function (req, res) { const passportAuthenticateAsync = function (req, res) {
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {
passport.authenticate('core.api', { session: false }, (err, user) => { passport.authenticate('core.api', (err, user) => {
if (err) { if (err) {
reject(err); reject(err);
} else { } else {
resolve(user); resolve(user);
res.on('finish', writeRouter.cleanup.bind(null, req));
} }
})(req, res); })(req, res);
}); });

4
src/routes/write/index.js
View File

@@ -63,3 +63,7 @@ Write.reload = async (params) => {
helpers.formatApiResponse(404, res); helpers.formatApiResponse(404, res);
}); });
}; };
Write.cleanup = (req) => {
req.session.destroy();
};