Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-01 11:35:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

re: #5211, broke out meta.css.minify to accept targets, made build output marginally nicer looking

Browse Source
This commit is contained in:
Julian Lam
2016-11-17 12:11:56 -05:00
parent 232b387652
commit 9bab0b53b0
2 changed files with 30 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
app.js
View File

@@ -280,9 +280,9 @@ function build(targets, callback) {
var db = require('./src/database');
var meta = require('./src/meta');
var plugins = require('./src/plugins');
var valid = ['js', 'css', 'tpl'];
var valid = ['js', 'clientCSS', 'acpCSS', 'tpl'];
var step = function (target, next) {
winston.info('[build] Build step completed in ' + ((Date.now() - startTime) / 1000) + 's');
winston.info('[build] => Completed in ' + ((Date.now() - startTime) / 1000) + 's');
next();
};
var startTime;
@@ -318,10 +318,16 @@ function build(targets, callback) {
], step.bind(this, target, next));
break;
case 'css':
winston.info('[build] Building CSS stylesheets');
case 'clientCSS':
winston.info('[build] Building client-side CSS');
startTime = Date.now();
meta.css.minify(step.bind(this, target, next));
meta.css.minify('stylesheet.css', step.bind(this, target, next));
break;
case 'acpCSS':
winston.info('[build] Building admin control panel CSS');
startTime = Date.now();
meta.css.minify('admin.css', step.bind(this, target, next));
break;
case 'tpl':

13
src/meta/css.js
View File

@@ -21,7 +21,7 @@ module.exports = function (Meta) {
Meta.css.cache = undefined;
Meta.css.acpCache = undefined;
Meta.css.minify = function (callback) {
Meta.css.minify = function (target, callback) {
callback = callback || function () {};
winston.verbose('[meta/css] Minifying LESS/CSS');
@@ -61,6 +61,7 @@ module.exports = function (Meta) {
var acpSource = source;
if (target !== 'admin.css') {
source += '\n@import (inline) "..' + path.sep + '..' + path.sep + 'public/vendor/jquery/css/smoothness/jquery-ui.css";';
source += '\n@import (inline) "..' + path.sep + '..' + path.sep + 'public/vendor/jquery/bootstrap-tagsinput/bootstrap-tagsinput.css";';
source += '\n@import (inline) "..' + path.sep + 'public/vendor/colorpicker/colorpicker.css";';
@@ -71,17 +72,15 @@ module.exports = function (Meta) {
source += '\n@import "..' + path.sep + '..' + path.sep + 'public/less/global.less";';
source = '@import "./theme";\n' + source;
minify(source, paths, 'cache', callback);
} else {
acpSource += '\n@import "..' + path.sep + 'public/less/admin/admin";\n';
acpSource += '\n@import "..' + path.sep + 'public/less/generics.less";\n';
acpSource += '\n@import (inline) "..' + path.sep + 'public/vendor/colorpicker/colorpicker.css";\n';
acpSource += '\n@import (inline) "..' + path.sep + 'public/vendor/jquery/css/smoothness/jquery-ui.css";';
async.series([
async.apply(minify, source, paths, 'cache'),
async.apply(minify, acpSource, paths, 'acpCache')
], function (err) {
callback(err);
});
minify(acpSource, paths, 'acpCache', callback);
}
});
});
};