Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-01-01 21:30:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: #10068, baseIndex should be read before sort update fix off by one error

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2021-12-08 09:41:48 -05:00
parent 45d8157fee
commit 9af2335134
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
public/src/client/category/tools.js
View File

@@ -284,14 +284,17 @@ define('forum/category/tools', [
const topicListEl = $('[component="category"]').filter(function (i, e) {
return !$(e).parents('[widget-area],[data-widget-area]').length;
});
let baseIndex = 0;
topicListEl.sortable({
handle: '[component="topic/pinned"]',
items: '[component="category/topic"].pinned',
start: function () {
baseIndex = parseInt(topicListEl.find('[component="category/topic"].pinned').first().attr('data-index'), 10);
},
update: function (ev, ui) {
const baseIndex = parseInt(topicListEl.find('[component="category/topic"].pinned').first().attr('data-index'), 10);
socket.emit('topics.orderPinnedTopics', {
tid: ui.item.attr('data-tid'),
order: baseIndex + ui.item.index() - 1,
order: baseIndex + ui.item.index(),
}, function (err) {
if (err) {
return alerts.error(err);