post tools test

src/socket.io/posts/tools.js

@@ -15,10 +15,11 @@ var social = require('../../social');
 module.exports = function (SocketPosts) {
 
 	SocketPosts.loadPostTools = function (socket, data, callback) {
-		if (!data) {
+		if (!data || !data.pid || !data.cid) {
 			return callback(new Error('[[error:invalid-data]]'));
 		}
-
+		async.waterfall([
+			function (next) {
 				async.parallel({
 					posts: function (next) {
 						posts.getPostFields(data.pid, ['deleted', 'bookmarks', 'uid'], next);
@@ -41,11 +42,9 @@ module.exports = function (SocketPosts) {
 					postSharing: function (next) {
 						social.getActivePostSharing(next);
 					}
-		}, function (err, results) {
+				}, next);
-			if (err) {
+			},
-				return callback(err);
+			function (results, next) {
-			}
-
 				results.posts.tools = results.tools.tools;
 				results.posts.deleted = parseInt(results.posts.deleted, 10) === 1;
 				results.posts.bookmarked = results.bookmarked;
@@ -54,8 +53,9 @@ module.exports = function (SocketPosts) {
 				results.posts.display_delete_tools = results.canDelete.flag;
 				results.posts.display_moderator_tools = results.posts.display_edit_tools || results.posts.display_delete_tools;
 				results.posts.display_move_tools = results.isAdminOrMod;
-			callback(null, results);
+				next(null, results);
-		});
+			}
+		], callback);
 	};
 
 	SocketPosts.delete = function (socket, data, callback) {
@@ -98,10 +98,11 @@ module.exports = function (SocketPosts) {
 			return callback(new Error('[[error:invalid-data]]'));
 		}
 
-		posts.tools.restore(socket.uid, data.pid, function (err, postData) {
+		async.waterfall([
-			if (err) {
+			function (next) {
-				return callback(err);
+				posts.tools.restore(socket.uid, data.pid, next);
-			}
+			},
+			function (postData, next) {
 
 				websockets.in('topic_' + data.tid).emit('event:post_restored', postData);
 
@@ -112,15 +113,16 @@ module.exports = function (SocketPosts) {
 					ip: socket.ip
 				});
 
-			callback();
+				setImmediate(next);
-		});
+			}
+		], callback);
 	};
 
 	SocketPosts.deletePosts = function (socket, data, callback) {
 		if (!data || !Array.isArray(data.pids)) {
 			return callback(new Error('[[error:invalid-data]]'));
 		}
-		async.each(data.pids, function (pid, next) {
+		async.eachSeries(data.pids, function (pid, next) {
 			SocketPosts.delete(socket, {pid: pid, tid: data.tid}, next);
 		}, callback);
 	};
@@ -129,15 +131,29 @@ module.exports = function (SocketPosts) {
 		if (!data || !Array.isArray(data.pids)) {
 			return callback(new Error('[[error:invalid-data]]'));
 		}
-		async.each(data.pids, function (pid, next) {
+		async.eachSeries(data.pids, function (pid, next) {
 			SocketPosts.purge(socket, {pid: pid, tid: data.tid}, next);
 		}, callback);
 	};
 
 	SocketPosts.purge = function (socket, data, callback) {
-		function purgePost() {
+		if (!data || !parseInt(data.pid, 10)) {
+			return callback(new Error('[[error:invalid-data]]'));
+		}
 		var postData;
 		async.waterfall([
+			function (next) {
+				isMainAndLastPost(data.pid, next);
+			},
+			function (results, next) {
+				if (results.isMain && !results.isLast) {
+					return callback(new Error('[[error:cant-purge-main-post]]'));
+				}
+				if (results.isMain && results.isLast) {
+					deleteTopicOf(data.pid, socket, next);
+				}
+				setImmediate(next);
+			},
 			function (next) {
 				posts.getPostField(data.pid, 'toPid', next);
 			},
@@ -159,36 +175,17 @@ module.exports = function (SocketPosts) {
 				}, next);
 			}
 		], callback);
-		}
-
-		if (!data || !parseInt(data.pid, 10)) {
-			return callback(new Error('[[error:invalid-data]]'));
-		}
-
-		isMainAndLastPost(data.pid, function (err, results) {
-			if (err) {
-				return callback(err);
-			}
-
-			if (!results.isMain) {
-				return purgePost();
-			}
-
-			if (!results.isLast) {
-				return callback(new Error('[[error:cant-purge-main-post]]'));
-			}
-
-			deleteTopicOf(data.pid, socket, callback);
-		});
 	};
 
 	function deleteTopicOf(pid, socket, callback) {
-		posts.getTopicFields(pid, ['tid', 'cid'], function (err, topic) {
+		async.waterfall([
-			if (err) {
+			function (next) {
-				return callback(err);
+				posts.getTopicFields(pid, ['tid', 'cid'], next);
+			},
+			function (topic, next) {
+				socketTopics.doTopicAction('delete', 'event:topic_deleted', socket, {tids: [topic.tid], cid: topic.cid}, next);
 			}
-			socketTopics.doTopicAction('delete', 'event:topic_deleted', socket, {tids: [topic.tid], cid: topic.cid}, callback);
+		], callback);
-		});
 	}
 
 	function isMainAndLastPost(pid, callback) {

src/socket.io/topics/tools.js

@@ -1,7 +1,6 @@
 'use strict';
 
 var async = require('async');
-var winston = require('winston');
 var validator = require('validator');
 
 var topics = require('../../topics');
@@ -89,31 +88,37 @@ module.exports = function (SocketTopics) {
 		}
 
 		async.each(data.tids, function (tid, next) {
-			topics.tools[action](tid, socket.uid, function (err, data) {
+			async.waterfall([
-				if (err) {
+				function (next) {
-					return next(err);
+					topics.tools[action](tid, socket.uid, next);
-				}
+				},
-
+				function (data, next) {
 					socketHelpers.emitToTopicAndCategory(event, data);
-
+					logTopicAction(action, socket, tid, next);
-				if (action === 'delete' || action === 'restore' || action === 'purge') {
-					topics.getTopicField(tid, 'title', function (err, title) {
-						if (err) {
-							return winston.error(err);
 				}
+			], next);
+		}, callback);
+	};
+
+	function logTopicAction(action, socket, tid, callback) {
+		var actionsToLog = ['delete', 'restore', 'purge'];
+		if (actionsToLog.indexOf(action) === -1) {
+			return setImmediate(callback);
+		}
+		async.waterfall([
+			function (next) {
+				topics.getTopicField(tid, 'title', next);
+			},
+			function (title, next) {
 				events.log({
 					type: 'topic-' + action,
 					uid: socket.uid,
 					ip: socket.ip,
 					tid: tid,
 					title: validator.escape(String(title))
-						});
+				}, next);
-					});
+			}
+		], callback);
 	}
 
-				next();
-			});
-		}, callback);
-	};
-
 };

test/posts.js

@@ -162,10 +162,44 @@ describe('Post\'s', function () {
 		});
 	});
 
+	describe('post tools', function () {
+		var socketPosts = require('../src/socket.io/posts');
+
+		it('should error if data is invalid', function (done) {
+			socketPosts.loadPostTools({uid: globalModUid}, null, function (err) {
+				assert.equal(err.message, '[[error:invalid-data]]');
+				done();
+			});
+		});
+
+		it('should load post tools', function (done) {
+			socketPosts.loadPostTools({uid: globalModUid}, {pid: postData.pid, cid: cid}, function (err, data) {
+				assert.ifError(err);
+				assert(data.posts.display_edit_tools);
+				assert(data.posts.display_delete_tools);
+				assert(data.posts.display_moderator_tools);
+				assert(data.posts.display_move_tools);
+				done();
+			});
+		});
+	});
+
 	describe('delete/restore/purge', function () {
-		var pid;
+		var tid;
+		var mainPid;
+		var replyPid;
+
 		var socketPosts = require('../src/socket.io/posts');
 		before(function (done) {
+			topics.post({
+				uid: voterUid,
+				cid: cid,
+				title: 'topic to delete/restore/purge',
+				content: 'A post to delete/restore/purge'
+			}, function (err, data) {
+				assert.ifError(err);
+				tid = data.topicData.tid;
+				mainPid = data.postData.pid;
 				topics.reply({
 					uid: voterUid,
 					tid: topicData.tid,
@@ -173,15 +207,23 @@ describe('Post\'s', function () {
 					content: 'A post to delete/restore and purge'
 				}, function (err, data) {
 					assert.ifError(err);
-				pid = data.pid;
+					replyPid = data.pid;
 					privileges.categories.give(['purge'], cid, 'registered-users', done);
 				});
 			});
+		});
+
+		it('should error with invalid data', function (done) {
+			socketPosts.delete({uid: voterUid}, null, function (err) {
+				assert.equal(err.message, '[[error:invalid-data]]');
+				done();
+			});
+		});
 
 		it('should delete a post', function (done) {
-			socketPosts.delete({uid: voterUid}, {pid: pid, tid: topicData.tid}, function (err) {
+			socketPosts.delete({uid: voterUid}, {pid: replyPid, tid: tid}, function (err) {
 				assert.ifError(err);
-				posts.getPostField(pid, 'deleted', function (err, isDeleted) {
+				posts.getPostField(replyPid, 'deleted', function (err, isDeleted) {
 					assert.ifError(err);
 					assert.equal(parseInt(isDeleted, 10), 1);
 					done();
@@ -190,9 +232,9 @@ describe('Post\'s', function () {
 		});
 
 		it('should restore a post', function (done) {
-			socketPosts.restore({uid: voterUid}, {pid: pid, tid: topicData.tid}, function (err) {
+			socketPosts.restore({uid: voterUid}, {pid: replyPid, tid: tid}, function (err) {
 				assert.ifError(err);
-				posts.getPostField(pid, 'deleted', function (err, isDeleted) {
+				posts.getPostField(replyPid, 'deleted', function (err, isDeleted) {
 					assert.ifError(err);
 					assert.equal(parseInt(isDeleted, 10), 0);
 					done();
@@ -200,10 +242,24 @@ describe('Post\'s', function () {
 			});
 		});
 
-		it('should purge a post', function (done) {
+		it('should delete posts and topic', function (done) {
-			socketPosts.purge({uid: voterUid}, {pid: pid}, function (err) {
+			socketPosts.deletePosts({uid: globalModUid}, {pids: [replyPid, mainPid], tid: tid}, function (err) {
 				assert.ifError(err);
-				posts.exists('post:' + pid, function (err, exists) {
+				topics.getTopicField(tid, 'deleted', function (err, deleted) {
+					assert.ifError(err);
+					assert.equal(parseInt(deleted, 10), 1);
+					done();
+				});
+			});
+		});
+
+		it('should purge posts', function (done) {
+			var socketTopics = require('../src/socket.io/topics');
+			socketTopics.restore({uid: globalModUid}, {tids: [tid], cid: cid}, function (err) {
+				assert.ifError(err);
+				socketPosts.purgePosts({uid: voterUid}, {pids: [replyPid, mainPid], tid: tid}, function (err) {
+					assert.ifError(err);
+					posts.exists('post:' + replyPid, function (err, exists) {
 						assert.ifError(err);
 						assert.equal(exists, false);
 						done();
@@ -211,6 +267,7 @@ describe('Post\'s', function () {
 				});
 			});
 		});
+	});
 
 	describe('edit', function () {
 		var pid;