Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-29 10:06:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: #12990, local references via remote posts are not linkified properly, + tests for helper

Browse Source
This commit is contained in:
Julian Lam
2025-01-15 14:19:39 -05:00
parent 3ba1d26427
commit 98280d30e7
2 changed files with 65 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/activitypub/helpers.js
View File

@@ -366,19 +366,29 @@ Helpers.remoteAnchorToLocalProfile = async (content) => {
return content;
}
// Filter out urls that don't backreference to a remote id
const urlMap = new Map();
const urlsArray = Array.from(urls);
// Local references
const localUrls = urlsArray.filter(url => url.startsWith(nconf.get('url')));
await Promise.all(localUrls.map(async (url) => {
const { type, id } = await Helpers.resolveLocalId(url);
if (type === 'user') {
urlMap.set(url, id);
} // else if (type === 'category') {
}));
// Remote references
const [backrefs, urlAsIdExists] = await Promise.all([
db.getObjectFields('remoteUrl:uid', urlsArray),
db.isSortedSetMembers('usersRemote:lastCrawled', urlsArray),
]);
const urlMap = new Map();
urlsArray.forEach((url, index) => {
if (backrefs[url] || urlAsIdExists[index]) {
urlMap.set(url, backrefs[url] || url);
}
});
let slugs = await user.getUsersFields(Array.from(urlMap.values()), ['userslug']);
slugs = slugs.map(({ userslug }) => userslug);
Array.from(urlMap.keys()).forEach((url, idx) => {