Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: bookmark in topic data is nullable now

Browse Source 
This prevents the superfluous "/1" being appended to all topics you've never been into.

This looks to be a change in the public API but the documented API lists this property as nullable already, so it looks like this commit is actually *restoring* proper behaviour.
This commit is contained in:
Julian Lam
2024-01-17 23:11:16 -05:00
parent 60bc27ec69
commit 970a5a6e5f
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/topics/index.js
View File

@@ -138,9 +138,9 @@ Topics.getTopicsByTids = async function (tids, options) {
topic.isOwner = topic.uid === parseInt(uid, 10);
topic.ignored = isIgnored[i];
topic.unread = parseInt(uid, 10) <= 0 || (!hasRead[i] && !isIgnored[i]);
topic.bookmark = sortNewToOld ?
topic.bookmark = bookmarks[i] && (sortNewToOld ?
Math.max(1, topic.postcount + 2 - bookmarks[i]) :
Math.min(topic.postcount, bookmarks[i] + 1);
Math.min(topic.postcount, bookmarks[i] + 1));
topic.unreplied = !topic.teaser;
topic.icons = [];