Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-12-23 00:40:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: wrap majority of note assertion logic in try..catch to handle exceptions so that the lock is always released

Browse Source
This commit is contained in:
Julian Lam
2025-09-11 10:30:21 -04:00
parent 4f5e770c5f
commit 95fb084ca4
1 changed files with 200 additions and 194 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/activitypub/notes.js
View File

@@ -64,6 +64,7 @@ Notes.assert = async (uid, input, options = { skipChecks: false }) => {
return null; return null;
} }
try {
if (!options.skipChecks) { if (!options.skipChecks) {
id = (await activitypub.checkHeader(id)) || id; id = (await activitypub.checkHeader(id)) || id;
} }
@@ -271,6 +272,11 @@ Notes.assert = async (uid, input, options = { skipChecks: false }) => {
]); ]);
return { tid, count }; return { tid, count };
} catch (e) {
winston.warn(`[activitypub/notes.assert] Could not assert ${id} (${e.message}), releasing lock.`);
await unlock(id);
return null;
}
}; };
Notes.assertPrivate = async (object) => { Notes.assertPrivate = async (object) => {