Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 08:36:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

test: add test for undefined fields in getObjectsFields

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2021-04-22 11:14:47 -04:00
parent 75f7972b88
commit 92de49be00
3 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/database/mongo/hash.js
View File

@@ -120,7 +120,7 @@ module.exports = function (module) {
cache.set(key, cachedData[key]);
});
if (!fields.length) {
if (!Array.isArray(fields) || !fields.length) {
return keys.map(key => (cachedData[key] ? { ...cachedData[key] } : null));
}
return keys.map((key) => {

7
src/database/postgres/hash.js
View File

@@ -142,7 +142,9 @@ SELECT h."data"->>$2::TEXT f
if (!key) {
return null;
}
if (!Array.isArray(fields) || !fields.length) {
return await module.getObject(key);
}
const res = await module.pool.query({
name: 'getObjectFields',
text: `
@@ -174,7 +176,8 @@ SELECT (SELECT jsonb_object_agg(f, d."value")
if (!Array.isArray(keys) || !keys.length) {
return [];
}
if (!fields.length) {
if (!Array.isArray(fields) || !fields.length) {
return await module.getObjects(keys);
}
const res = await module.pool.query({

9
test/database/hash.js
View File

@@ -324,6 +324,15 @@ describe('Hash methods', () => {
assert.strictEqual(Number(objects[1].age), 3);
assert.strictEqual(!!objects[2], false);
});
it('should return objects if fields is not an array', async () => {
const objects = await db.getObjectsFields(['testObject8', 'testObject9', 'doesnotexist'], undefined);
assert.strictEqual(objects[0].name, 'baris');
assert.strictEqual(Number(objects[0].age), 99);
assert.strictEqual(objects[1].name, 'ginger');
assert.strictEqual(Number(objects[1].age), 3);
assert.strictEqual(!!objects[2], false);
});
});
describe('getObjectKeys()', () => {