Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

test: use encoded parameters in webfinger tests

Browse Source
This commit is contained in:
Opliko
2024-04-25 12:00:31 +02:00
parent 3d1e2cde6a
commit 8fd4ae2d8f
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
test/activitypub.js
View File

@@ -39,14 +39,14 @@ describe('ActivityPub integration', () => {
}); });
it('should return a 404 Not Found if no user exists by that username', async () => { it('should return a 404 Not Found if no user exists by that username', async () => {
const { response } = await request.get(`${nconf.get('url')}/.well-known/webfinger?resource=acct:foobar@${host}`); const { response } = await request.get(`${nconf.get('url')}/.well-known/webfinger?resource=acct%3afoobar%40${host}`);
assert(response); assert(response);
assert.strictEqual(response.statusCode, 404); assert.strictEqual(response.statusCode, 404);
}); });
it('should return a 400 Bad Request if the request is malformed', async () => { it('should return a 400 Bad Request if the request is malformed', async () => {
const { response } = await request.get(`${nconf.get('url')}/.well-known/webfinger?resource=acct:foobar`); const { response } = await request.get(`${nconf.get('url')}/.well-known/webfinger?resource=acct%3afoobar`);
assert(response); assert(response);
assert.strictEqual(response.statusCode, 400); assert.strictEqual(response.statusCode, 400);
@@ -54,7 +54,7 @@ describe('ActivityPub integration', () => {
it('should return 403 Forbidden if the calling user is not allowed to view the user list/profiles', async () => { it('should return 403 Forbidden if the calling user is not allowed to view the user list/profiles', async () => {
await privileges.global.rescind(['groups:view:users'], 'guests'); await privileges.global.rescind(['groups:view:users'], 'guests');
const { response } = await request.get(`${nconf.get('url')}/.well-known/webfinger?resource=acct:${slug}@${host}`); const { response } = await request.get(`${nconf.get('url')}/.well-known/webfinger?resource=acct%3a${slug}%40${host}`);
assert(response); assert(response);
assert.strictEqual(response.statusCode, 400); assert.strictEqual(response.statusCode, 400);
@@ -62,7 +62,7 @@ describe('ActivityPub integration', () => {
}); });
it('should return a valid WebFinger response otherwise', async () => { it('should return a valid WebFinger response otherwise', async () => {
const { response, body } = await request.get(`${nconf.get('url')}/.well-known/webfinger?resource=acct:${slug}@${host}`); const { response, body } = await request.get(`${nconf.get('url')}/.well-known/webfinger?resource=acct%3a${slug}%40${host}`);
assert(response); assert(response);
assert.strictEqual(response.statusCode, 200); assert.strictEqual(response.statusCode, 200);
@@ -140,13 +140,13 @@ describe('ActivityPub integration', () => {
}); });
it('should return null when valid input is passed but does not resolve', async () => { it('should return null when valid input is passed but does not resolve', async () => {
const { type, id } = await activitypub.helpers.resolveLocalId(`acct:foobar@${nconf.get('url_parsed').host}`); const { type, id } = await activitypub.helpers.resolveLocalId(`acct%3afoobar@${nconf.get('url_parsed').host}`);
assert.strictEqual(type, 'user'); assert.strictEqual(type, 'user');
assert.strictEqual(id, null); assert.strictEqual(id, null);
}); });
it('should resolve to a local uid when given a webfinger-style string', async () => { it('should resolve to a local uid when given a webfinger-style string', async () => {
const { id } = await activitypub.helpers.resolveLocalId(`acct:${slug}@${nconf.get('url_parsed').host}`); const { id } = await activitypub.helpers.resolveLocalId(`acct%3a${slug}@${nconf.get('url_parsed').host}`);
assert.strictEqual(id, uid); assert.strictEqual(id, uid);
}); });
@@ -291,7 +291,7 @@ describe('ActivityPub integration', () => {
}); });
it('should also have a valid WebFinger response tied to `preferredUsername`', async () => { it('should also have a valid WebFinger response tied to `preferredUsername`', async () => {
const { response, body: body2 } = await request.get(`${nconf.get('url')}/.well-known/webfinger?resource=acct:${body.preferredUsername}@${nconf.get('url_parsed').host}`); const { response, body: body2 } = await request.get(`${nconf.get('url')}/.well-known/webfinger?resource=acct%3a${body.preferredUsername}@${nconf.get('url_parsed').host}`);
assert.strictEqual(response.statusCode, 200); assert.strictEqual(response.statusCode, 200);
assert(body2 && body2.aliases && body2.links); assert(body2 && body2.aliases && body2.links);