Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-01 03:26:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

Deprecated action:user.loggedOut, updated plugin deprecation notices

Browse Source 
... to show replacement, if available.
This commit is contained in:
Julian Lam
2016-01-07 15:41:51 -05:00
parent aa30973f0a
commit 8fa2c34fc5
2 changed files with 16 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/controllers/authentication.js
View File

@@ -280,9 +280,12 @@ authenticationController.logout = function(req, res, next) {
} }
req.logout(); req.logout();
// action:user.loggedOut deprecated in > v0.9.3
plugins.fireHook('action:user.loggedOut', {req: req, res: res, uid: uid}); plugins.fireHook('action:user.loggedOut', {req: req, res: res, uid: uid});
plugins.fireHook('static:user.loggedOut', {req: req, res: res, uid: uid}, function() {
res.status(200).send(''); res.status(200).send('');
}); });
});
} else { } else {
res.status(200).send(''); res.status(200).send('');
} }

18
src/plugins/hooks.js
View File

@@ -4,10 +4,11 @@ var winston = require('winston'),
async = require('async'); async = require('async');
module.exports = function(Plugins) { module.exports = function(Plugins) {
Plugins.deprecatedHooks = [ Plugins.deprecatedHooks = {
'filter:user.delete', 'filter:user.delete': 'static:user.delete',
'filter:user.custom_fields' 'filter:user.custom_fields': null,
]; 'action:user.loggedOut': 'static:user.loggedOut'
};
/* /*
`data` is an object consisting of (* is required): `data` is an object consisting of (* is required):
@@ -27,8 +28,13 @@ module.exports = function(Plugins) {
var method; var method;
if (Plugins.deprecatedHooks.indexOf(data.hook) !== -1) { if (Object.keys(Plugins.deprecatedHooks).indexOf(data.hook) !== -1) {
winston.warn('[plugins/' + id + '] Hook `' + data.hook + '` is deprecated, please use an alternative'); winston.warn('[plugins/' + id + '] Hook `' + data.hook + '` is deprecated, ' +
(Plugins.deprecatedHooks[data.hook] ?
'please use `' + Plugins.deprecatedHooks[data.hook] + '` instead.' :
'there is no alternative.'
)
);
} }
if (data.hook && data.method) { if (data.hook && data.method) {