Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 08:36:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: tests, get latest release tag recursively

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2020-10-07 18:14:45 -04:00
parent 804729fcec
commit 8eb62e2210
1 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/admin/versions.js
View File

@@ -10,8 +10,8 @@ let versionCacheLastModified = '';
const isPrerelease = /^v?\d+\.\d+\.\d+-.+$/;
function getLatestVersion(callback) {
var headers = {
function getLatestRelease(page, callback) {
const headers = {
Accept: 'application/vnd.github.v3+json',
'User-Agent': encodeURIComponent('NodeBB Admin Control Panel/' + meta.config.title),
};
@@ -19,8 +19,7 @@ function getLatestVersion(callback) {
if (versionCacheLastModified) {
headers['If-Modified-Since'] = versionCacheLastModified;
}
request('https://api.github.com/repos/NodeBB/NodeBB/tags', {
request('https://api.github.com/repos/NodeBB/NodeBB/tags?page=' + page, {
json: true,
headers: headers,
timeout: 1000,
@@ -34,7 +33,7 @@ function getLatestVersion(callback) {
}
if (res.statusCode !== 200) {
return callback(Error(res.statusMessage));
return callback(new Error(res.statusMessage));
}
releases = releases.filter(function (version) {
@@ -45,6 +44,9 @@ function getLatestVersion(callback) {
return semver.lt(a, b) ? 1 : -1;
});
if (!releases.length) {
return getLatestRelease(page + 1, callback);
}
versionCache = releases[0];
versionCacheLastModified = res.headers['last-modified'];
@@ -52,6 +54,10 @@ function getLatestVersion(callback) {
});
}
function getLatestVersion(callback) {
getLatestRelease(1, callback);
}
exports.getLatestVersion = getLatestVersion;
exports.isPrerelease = isPrerelease;