Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-02 12:05:57 +01:00
Code Issues Packages Projects Releases Wiki Activity

closes #5912

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2017-12-07 20:43:02 -05:00
parent 6d6a45c9fa
commit 8e04e86e24
2 changed files with 62 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/database/mongo/sorted.js
View File

@@ -41,6 +41,22 @@ module.exports = function (db, module) {
key = { $in: key }; key = { $in: key };
} }
if (start < 0 && start > stop) {
return callback(null, []);
}
var reverse = false;
if (start === 0 && stop < -1) {
reverse = true;
sort *= -1;
start = Math.abs(stop + 1);
stop = -1;
} else if (start < 0 && stop > start) {
var tmp1 = Math.abs(stop + 1);
stop = Math.abs(start + 1);
start = tmp1;
}
var limit = stop - start + 1; var limit = stop - start + 1;
if (limit <= 0) { if (limit <= 0) {
limit = 0; limit = 0;
@@ -54,7 +70,9 @@ module.exports = function (db, module) {
if (err || !data) { if (err || !data) {
return callback(err); return callback(err);
} }
if (reverse) {
data.reverse();
}
if (!withScores) { if (!withScores) {
data = data.map(function (item) { data = data.map(function (item) {
return item.value; return item.value;

43
test/database/sorted.js
View File

@@ -78,6 +78,49 @@ describe('Sorted Set methods', function () {
done(); done();
}); });
}); });
it('should handle negative start/stop', function (done) {
db.sortedSetAdd('negatives', [1, 2, 3, 4, 5], ['1', '2', '3', '4', '5'], function (err) {
assert.ifError(err);
db.getSortedSetRange('negatives', -2, -4, function (err, data) {
assert.ifError(err);
assert.deepEqual(data, []);
done();
});
});
});
it('should handle negative start/stop', function (done) {
db.getSortedSetRange('negatives', -4, -2, function (err, data) {
assert.ifError(err);
assert.deepEqual(data, ['2', '3', '4']);
done();
});
});
it('should handle negative start/stop', function (done) {
db.getSortedSetRevRange('negatives', -4, -2, function (err, data) {
assert.ifError(err);
assert.deepEqual(data, ['4', '3', '2']);
done();
});
});
it('should handle negative start/stop', function (done) {
db.getSortedSetRange('negatives', -5, -1, function (err, data) {
assert.ifError(err);
assert.deepEqual(data, ['1', '2', '3', '4', '5']);
done();
});
});
it('should handle negative start/stop', function (done) {
db.getSortedSetRange('negatives', 0, -2, function (err, data) {
assert.ifError(err);
assert.deepEqual(data, ['1', '2', '3', '4']);
done();
});
});
}); });
describe('getSortedSetRevRange()', function () { describe('getSortedSetRevRange()', function () {