Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: tests, handle no sessions

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2020-05-16 22:17:20 -04:00
parent a0d76ff0a6
commit 8bf980cb63
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/controllers/authentication.js
View File

@@ -350,10 +350,12 @@ authenticationController.onSuccessfulLogin = async function (req, uid) {
}); });
await Promise.all([ await Promise.all([
user.auth.addSession(uid, req.sessionID), user.auth.addSession(uid, req.sessionID),
(uid > 0) ? db.setObjectField('uid:' + uid + ':sessionUUID:sessionId', uuid, req.sessionID) : null,
user.updateLastOnlineTime(uid), user.updateLastOnlineTime(uid),
user.updateOnlineUsers(uid), user.updateOnlineUsers(uid),
]); ]);
if (uid > 0) {
await db.setObjectField('uid:' + uid + ':sessionUUID:sessionId', uuid, req.sessionID);
}
// Force session check for all connected socket.io clients with the same session id // Force session check for all connected socket.io clients with the same session id
sockets.in('sess_' + req.sessionID).emit('checkSession', uid); sockets.in('sess_' + req.sessionID).emit('checkSession', uid);

3
src/user/auth.js
View File

@@ -82,6 +82,9 @@ module.exports = function (User) {
async function cleanExpiredSessions(uid) { async function cleanExpiredSessions(uid) {
const uuidMapping = await db.getObject('uid:' + uid + ':sessionUUID:sessionId'); const uuidMapping = await db.getObject('uid:' + uid + ':sessionUUID:sessionId');
if (!uuidMapping) {
return;
}
const expiredUUIDs = []; const expiredUUIDs = [];
const expiredSids = []; const expiredSids = [];
await Promise.all(Object.keys(uuidMapping).map(async (uuid) => { await Promise.all(Object.keys(uuidMapping).map(async (uuid) => {