Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove 'filters' and 'categories' from flag details API return [breaking]

Browse Source 
These options were originally used when the flag filters were shown in the sidebar. This has seen been removed, and so the information is now superfluous
This commit is contained in:
Julian Lam
2021-01-25 12:13:09 -05:00
parent 1603566bcc
commit 8b72479f62
2 changed files with 0 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
public/openapi/read/flags/flagId.yaml
View File

@@ -205,17 +205,6 @@ get:
type: boolean type: boolean
title: title:
type: string type: string
categories:
type: object
additionalProperties:
type: string
filters:
type: object
properties:
page:
type: number
perPage:
type: number
privileges: privileges:
type: object type: object
properties: {} properties: {}

9
src/controllers/mods.js
View File

@@ -134,7 +134,6 @@ modsController.flags.detail = async function (req, res, next) {
moderatedCids: user.getModeratedCids(req.uid), moderatedCids: user.getModeratedCids(req.uid),
flagData: flags.get(req.params.flagId), flagData: flags.get(req.params.flagId),
assignees: user.getAdminsandGlobalModsandModerators(), assignees: user.getAdminsandGlobalModsandModerators(),
categories: categories.buildForSelect(req.uid, 'read'),
privileges: Promise.all(['global', 'admin'].map(async type => privileges[type].get(req.uid))), privileges: Promise.all(['global', 'admin'].map(async type => privileges[type].get(req.uid))),
}); });
results.privileges = { ...results.privileges[0], ...results.privileges[1] }; results.privileges = { ...results.privileges[0], ...results.privileges[1] };
@@ -145,12 +144,6 @@ modsController.flags.detail = async function (req, res, next) {
return next(new Error('[[error:no-privileges]]')); return next(new Error('[[error:no-privileges]]'));
} }
if (!results.isAdminOrGlobalMod && results.moderatedCids.length) {
res.locals.cids = results.moderatedCids;
}
results.categories = filterCategories(res.locals.cids, results.categories);
if (results.flagData.type === 'user') { if (results.flagData.type === 'user') {
results.flagData.type_path = 'uid'; results.flagData.type_path = 'uid';
} else if (results.flagData.type === 'post') { } else if (results.flagData.type === 'post') {
@@ -169,8 +162,6 @@ modsController.flags.detail = async function (req, res, next) {
return memo; return memo;
}, {}), }, {}),
title: '[[pages:flag-details, ' + req.params.flagId + ']]', title: '[[pages:flag-details, ' + req.params.flagId + ']]',
categories: results.categories,
filters: req.session.flags_filters || {},
privileges: results.privileges, privileges: results.privileges,
breadcrumbs: helpers.buildBreadcrumbs([ breadcrumbs: helpers.buildBreadcrumbs([
{ text: '[[pages:flags]]', url: '/flags' }, { text: '[[pages:flags]]', url: '/flags' },