Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-12-17 14:00:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: no need for moderate bit for global mods and admins

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2019-05-30 20:12:04 -04:00
parent d202be5b4f
commit 8aef689f05
4 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
public/src/modules/helpers.js
View File

@@ -182,9 +182,11 @@
return states.map(function (priv) { return states.map(function (priv) {
var guestDisabled = ['groups:moderate', 'groups:posts:upvote', 'groups:posts:downvote', 'groups:local:login', 'groups:group:create']; var guestDisabled = ['groups:moderate', 'groups:posts:upvote', 'groups:posts:downvote', 'groups:local:login', 'groups:group:create'];
var spidersEnabled = ['groups:find', 'groups:read', 'groups:topics:read', 'groups:view:users', 'groups:view:tags', 'groups:view:groups']; var spidersEnabled = ['groups:find', 'groups:read', 'groups:topics:read', 'groups:view:users', 'groups:view:tags', 'groups:view:groups'];
var globalModDisabled = ['groups:moderate'];
var disabled = var disabled =
(member === 'guests' && guestDisabled.includes(priv.name)) || (member === 'guests' && guestDisabled.includes(priv.name)) ||
(member === 'spiders' && !spidersEnabled.includes(priv.name)); (member === 'spiders' && !spidersEnabled.includes(priv.name)) ||
(member === 'Global Moderators' && globalModDisabled.includes(priv.name));
return '<td class="text-center" data-privilege="' + priv.name + '"><input type="checkbox"' + (priv.state ? ' checked' : '') + (disabled ? ' disabled="disabled"' : '') + ' /></td>'; return '<td class="text-center" data-privilege="' + priv.name + '"><input type="checkbox"' + (priv.state ? ' checked' : '') + (disabled ? ' disabled="disabled"' : '') + ' /></td>';
}).join(''); }).join('');

1
src/categories/create.js
View File

@@ -71,7 +71,6 @@ module.exports = function (Categories) {
const modPrivileges = defaultPrivileges.concat([ const modPrivileges = defaultPrivileges.concat([
'posts:view_deleted', 'posts:view_deleted',
'purge', 'purge',
'moderate',
]); ]);
async.series([ async.series([

1
src/upgrades/1.12.3/give_mod_privileges.js
View File

@@ -26,7 +26,6 @@ module.exports = {
const modPrivileges = defaultPrivileges.concat([ const modPrivileges = defaultPrivileges.concat([
'posts:view_deleted', 'posts:view_deleted',
'purge', 'purge',
'moderate',
]); ]);
const globalModPrivs = [ const globalModPrivs = [

4
test/categories.js
View File

@@ -849,9 +849,9 @@ describe('Categories', function () {
it('should retrieve all users with moderator bit in category privilege', function (done) { it('should retrieve all users with moderator bit in category privilege', function (done) {
Categories.getModeratorUids([1, 2], function (err, uids) { Categories.getModeratorUids([1, 2], function (err, uids) {
assert.ifError(err); assert.ifError(err);
assert.strictEqual(2, uids.length); assert.strictEqual(uids.length, 2);
assert(uids[0].includes('1')); assert(uids[0].includes('1'));
assert.strictEqual(1, uids[1].length); assert.strictEqual(uids[1].length, 0);
done(); done();
}); });
}); });