Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-31 11:05:54 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: #9827, fix reward duplication

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2021-09-22 23:56:34 -04:00
parent 1a61ffc595
commit 89af00d1d5
3 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
public/src/admin/extend/rewards.js
View File

@@ -167,11 +167,17 @@ define('admin/extend/rewards', [], function () {
activeRewards.push(data); activeRewards.push(data);
}); });
socket.emit('admin.rewards.save', activeRewards, function (err) { socket.emit('admin.rewards.save', activeRewards, function (err, result) {
if (err) { if (err) {
app.alertError(err.message); app.alertError(err.message);
} else { } else {
app.alertSuccess('[[admin/extend/rewards:alert.save-success]]'); app.alertSuccess('[[admin/extend/rewards:alert.save-success]]');
// newly added rewards are missing data-id, update to prevent rewards getting duplicated
$('#active li').each(function (index) {
if (!$(this).attr('data-id')) {
$(this).attr('data-id', result[index].id);
}
});
} }
}); });
} }

1
src/rewards/admin.js
View File

@@ -24,6 +24,7 @@ rewards.save = async function (data) {
await Promise.all(data.map(data => save(data))); await Promise.all(data.map(data => save(data)));
await saveConditions(data); await saveConditions(data);
return data;
}; };
rewards.delete = async function (data) { rewards.delete = async function (data) {

2
src/socket.io/admin/rewards.js
View File

@@ -5,7 +5,7 @@ const rewardsAdmin = require('../../rewards/admin');
const SocketRewards = module.exports; const SocketRewards = module.exports;
SocketRewards.save = async function (socket, data) { SocketRewards.save = async function (socket, data) {
await rewardsAdmin.save(data); return await rewardsAdmin.save(data);
}; };
SocketRewards.delete = async function (socket, data) { SocketRewards.delete = async function (socket, data) {