Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-01-01 13:20:41 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: #10067, count posts instead of incr/decr

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2021-12-07 18:40:23 -05:00
parent f4aa249d8c
commit 830166d120
4 changed files with 22 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/posts/delete.js
View File

@@ -84,7 +84,7 @@ module.exports = function (Posts) {
topics.updateTeaser(postData.tid),
topics.updateLastPostTimeFromLastPid(postData.tid),
db.sortedSetIncrBy(`tid:${postData.tid}:posters`, -1, postData.uid),
user.incrementUserPostCountBy(postData.uid, -1),
user.updatePostCount(postData.uid),
notifications.rescind(`new_post:tid:${postData.tid}:pid:${postData.pid}:uid:${postData.uid}`),
];

4
src/posts/user.js
View File

@@ -169,7 +169,7 @@ module.exports = function (Posts) {
db.setObjectField(pids.map(pid => `post:${pid}`), 'uid', toUid),
db.sortedSetRemoveBulk(bulkRemove),
db.sortedSetAddBulk(bulkAdd),
user.incrementUserPostCountBy(toUid, pids.length),
user.updatePostCount(toUid),
user.incrementUserReputationBy(toUid, repChange),
handleMainPidOwnerChange(postData, toUid),
reduceCounters(postsByUser),
@@ -187,7 +187,7 @@ module.exports = function (Posts) {
await async.eachOfSeries(postsByUser, async (posts, uid) => {
const repChange = posts.reduce((acc, val) => acc + val.votes, 0);
await Promise.all([
user.incrementUserPostCountBy(uid, -posts.length),
user.updatePostCount(uid),
user.incrementUserReputationBy(uid, -repChange),
]);
});

21
src/user/posts.js
View File

@@ -56,10 +56,11 @@ module.exports = function (User) {
// For scheduled posts, use "action" time. It'll be updated in related cron job when post is published
const lastposttime = postData.timestamp > Date.now() ? Date.now() : postData.timestamp;
await User.addPostIdToUser(postData);
await User.incrementUserPostCountBy(postData.uid, 1);
await User.setUserField(postData.uid, 'lastposttime', lastposttime);
await User.updateLastOnlineTime(postData.uid);
await Promise.all([
User.addPostIdToUser(postData),
User.setUserField(postData.uid, 'lastposttime', lastposttime),
User.updateLastOnlineTime(postData.uid),
]);
};
User.addPostIdToUser = async function (postData) {
@@ -67,6 +68,18 @@ module.exports = function (User) {
`uid:${postData.uid}:posts`,
`cid:${postData.cid}:uid:${postData.uid}:pids`,
], postData.timestamp, postData.pid);
await User.updatePostCount(postData.uid);
};
User.updatePostCount = async (uid) => {
const exists = await User.exists(uid);
if (exists) {
const count = await db.sortedSetCard(`uid:${uid}:posts`);
await Promise.all([
User.setUserField(uid, 'postcount', count),
db.sortedSetAdd('users:postcount', count, uid),
]);
}
};
User.incrementUserPostCountBy = async function (uid, value) {

4
test/user.js
View File

@@ -514,7 +514,7 @@ describe('User', () => {
});
});
it('should not re-add user to users:postcount if post is deleted after user deletion', async () => {
it('should not re-add user to users:postcount if post is purged after user account deletion', async () => {
const uid = await User.create({ username: 'olduserwithposts' });
assert(await db.isSortedSetMember('users:postcount', uid));
@@ -531,7 +531,7 @@ describe('User', () => {
assert(!await db.isSortedSetMember('users:postcount', uid));
});
it('should not re-add user to users:reputation if post is upvoted after user deletion', async () => {
it('should not re-add user to users:reputation if post is upvoted after user account deletion', async () => {
const uid = await User.create({ username: 'olduserwithpostsupvote' });
assert(await db.isSortedSetMember('users:reputation', uid));