Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-01 11:35:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

breaking: remove deprecated post diff socket calls

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2021-11-28 19:45:29 -05:00
parent 324262cbb5
commit 8117b7f22f
3 changed files with 18 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/socket.io/posts.js
View File

@@ -22,7 +22,6 @@ require('./posts/move')(SocketPosts);
require('./posts/votes')(SocketPosts);
require('./posts/bookmarks')(SocketPosts);
require('./posts/tools')(SocketPosts);
require('./posts/diffs')(SocketPosts);
SocketPosts.reply = async function (socket, data) {
sockets.warnDeprecated(socket, 'POST /api/v3/topics/:tid');

21
src/socket.io/posts/diffs.js
View File

@@ -1,21 +0,0 @@
'use strict';
const api = require('../../api');
const websockets = require('..');
module.exports = function (SocketPosts) {
SocketPosts.getDiffs = async function (socket, data) {
websockets.warnDeprecated(socket, 'GET /api/v3/posts/:pid/diffs');
return await api.posts.getDiffs(socket, data);
};
SocketPosts.showPostAt = async function (socket, data) {
websockets.warnDeprecated(socket, 'GET /api/v3/posts/:pid/diffs/:since');
return await api.posts.loadDiff(socket, data);
};
SocketPosts.restoreDiff = async function (socket, data) {
websockets.warnDeprecated(socket, 'PUT /api/v3/posts/:pid/diffs/:since');
return await api.posts.restoreDiff(socket, data);
};
};

35
test/posts.js
View File

@@ -18,6 +18,7 @@ const user = require('../src/user');
const groups = require('../src/groups');
const socketPosts = require('../src/socket.io/posts');
const socketTopics = require('../src/socket.io/topics');
const apiPosts = require('../src/api/posts');
const meta = require('../src/meta');
const helpers = require('./helpers');
@@ -625,28 +626,28 @@ describe('Post\'s', () => {
});
});
it('should not allow guests to view diffs', (done) => {
socketPosts.getDiffs({ uid: 0 }, { pid: 1 }, (err) => {
assert.equal(err.message, '[[error:no-privileges]]');
done();
});
it('should not allow guests to view diffs', async () => {
let err = {};
try {
await apiPosts.getDiffs({ uid: 0 }, { pid: 1 });
} catch (_err) {
err = _err;
}
assert.strictEqual(err.message, '[[error:no-privileges]]');
});
it('should allow registered-users group to view diffs', (done) => {
socketPosts.getDiffs({ uid: 1 }, { pid: 1 }, (err, data) => {
assert.ifError(err);
it('should allow registered-users group to view diffs', async () => {
const data = await apiPosts.getDiffs({ uid: 1 }, { pid: 1 });
assert.strictEqual('boolean', typeof data.editable);
assert.strictEqual(false, data.editable);
assert.strictEqual('boolean', typeof data.editable);
assert.strictEqual(false, data.editable);
assert.equal(true, Array.isArray(data.timestamps));
assert.strictEqual(1, data.timestamps.length);
assert.equal(true, Array.isArray(data.timestamps));
assert.strictEqual(1, data.timestamps.length);
assert.equal(true, Array.isArray(data.revisions));
assert.strictEqual(data.timestamps.length, data.revisions.length);
['timestamp', 'username'].every(prop => Object.keys(data.revisions[0]).includes(prop));
done();
});
assert.equal(true, Array.isArray(data.revisions));
assert.strictEqual(data.timestamps.length, data.revisions.length);
['timestamp', 'username'].every(prop => Object.keys(data.revisions[0]).includes(prop));
});
it('should not delete first diff of a post', async () => {