Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: tests

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2020-10-15 17:51:04 -04:00
parent e367c5403e
commit 7d86be2bc2
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/api/users.js
View File

@@ -20,6 +20,12 @@ usersAPI.create = async function (caller, data) {
}; };
usersAPI.update = async function (caller, data) { usersAPI.update = async function (caller, data) {
if (!data || !data.uid) {
throw new Error('[[error:invalid-data]]');
}
if (!caller.uid) {
throw new Error('[[error:invalid-uid]]');
}
const oldUserData = await user.getUserFields(data.uid, ['email', 'username']); const oldUserData = await user.getUserFields(data.uid, ['email', 'username']);
if (!oldUserData || !oldUserData.username) { if (!oldUserData || !oldUserData.username) {
throw new Error('[[error:invalid-data]]'); throw new Error('[[error:invalid-data]]');
@@ -66,6 +72,7 @@ usersAPI.update = async function (caller, data) {
if (userData.username !== oldUserData.username) { if (userData.username !== oldUserData.username) {
await log('username-change', { oldUsername: oldUserData.username, newUsername: userData.username }); await log('username-change', { oldUsername: oldUserData.username, newUsername: userData.username });
} }
return userData;
}; };
usersAPI.delete = async function (caller, data) { usersAPI.delete = async function (caller, data) {

4
test/user.js
View File

@@ -755,7 +755,7 @@ describe('User', function () {
describe('not logged in', function () { describe('not logged in', function () {
it('should return error if not logged in', function (done) { it('should return error if not logged in', function (done) {
socketUser.updateProfile({ uid: 0 }, {}, function (err) { socketUser.updateProfile({ uid: 0 }, { uid: 1 }, function (err) {
assert.equal(err.message, '[[error:invalid-uid]]'); assert.equal(err.message, '[[error:invalid-uid]]');
done(); done();
}); });
@@ -806,7 +806,7 @@ describe('User', function () {
birthday: '01/01/1980', birthday: '01/01/1980',
signature: 'nodebb is good', signature: 'nodebb is good',
}; };
socketUser.updateProfile({ uid: uid }, data, function (err, result) { socketUser.updateProfile({ uid: uid }, { ...data, password: '123456' }, function (err, result) {
assert.ifError(err); assert.ifError(err);
assert.equal(result.username, 'updatedUserName'); assert.equal(result.username, 'updatedUserName');