Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-07 22:45:46 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat: guard against accidental ommision

Browse Source 
...of analytics: prefix in get*StatsForSet methods
This commit is contained in:
Julian Lam
2020-02-07 10:28:32 -05:00
parent 14655f8745
commit 79737c53fd
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/analytics.js
View File

@@ -160,6 +160,7 @@ Analytics.getHourlyStatsForSet = async function (set, hour, numHours) {
} }
const counts = await db.sortedSetScores(set, hoursArr); const counts = await db.sortedSetScores(set, hoursArr);
console.log(hoursArr, counts);
hoursArr.forEach(function (term, index) { hoursArr.forEach(function (term, index) {
terms[term] = parseInt(counts[index], 10) || 0; terms[term] = parseInt(counts[index], 10) || 0;
@@ -176,6 +177,11 @@ Analytics.getHourlyStatsForSet = async function (set, hour, numHours) {
}; };
Analytics.getDailyStatsForSet = async function (set, day, numDays) { Analytics.getDailyStatsForSet = async function (set, day, numDays) {
// Guard again accidental ommission of `analytics:` prefix
if (!set.startsWith('analytics:')) {
set = 'analytics:' + set;
}
const daysArr = []; const daysArr = [];
day = new Date(day); day = new Date(day);
day.setDate(day.getDate() + 1); // set the date to tomorrow, because getHourlyStatsForSet steps *backwards* 24 hours to sum up the values day.setDate(day.getDate() + 1); // set the date to tomorrow, because getHourlyStatsForSet steps *backwards* 24 hours to sum up the values