Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: #9362 best not to check file exists on every page load; copying favicon to uploads/system folder instead

Browse Source
This commit is contained in:
psychobunny
2021-03-09 22:46:43 -05:00
parent ad5654952a
commit 771a8955a4
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

BIN
public/uploads/system/favicon.ico Normal file
View File

Binary file not shown.
Side by Side

After

Width:  |  Height:  |  Size: 1.1 KiB

7
src/meta/tags.js
View File

@@ -6,7 +6,6 @@ const winston = require('winston');
const plugins = require('../plugins'); const plugins = require('../plugins');
const Meta = require('./index'); const Meta = require('./index');
const utils = require('../utils'); const utils = require('../utils');
const file = require('./src/file');
const Tags = module.exports; const Tags = module.exports;
@@ -56,14 +55,14 @@ Tags.parse = async (req, data, meta, link) => {
}); });
} }
const uploadedFaviconPath = `${relative_path}/assets/uploads/system/favicon.ico`; const faviconPath = `${relative_path}/assets/uploads/system/favicon.ico`;
const faviconPath = await file.exists(uploadedFaviconPath) ? uploadedFaviconPath : `${relative_path}/favicon.ico`; const cacheBuster = `${Meta.config['cache-buster'] ? `?${Meta.config['cache-buster']}` : ''}`;
// Link Tags // Link Tags
const defaultLinks = [{ const defaultLinks = [{
rel: 'icon', rel: 'icon',
type: 'image/x-icon', type: 'image/x-icon',
href: `${faviconPath}${Meta.config['cache-buster'] ? `?${Meta.config['cache-buster']}` : ''}`, href: `${faviconPath}${cacheBuster}`,
}, { }, {
rel: 'manifest', rel: 'manifest',
href: `${relative_path}/manifest.webmanifest`, href: `${relative_path}/manifest.webmanifest`,