Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-30 18:46:01 +01:00
Code Issues Packages Projects Releases Wiki Activity

optimized User.getUsers

Browse Source
This commit is contained in:
barisusakli
2014-08-06 12:39:14 -04:00
parent 59d4d2880f
commit 76b257f7b8
2 changed files with 30 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
src/user.js
View File

@@ -239,36 +239,32 @@ var bcrypt = require('bcryptjs'),
};
User.getUsers = function(uids, callback) {
function loadUserInfo(user, callback) {
if (!user) {
return callback(null, user);
async.parallel({
userData: function(next) {
User.getMultipleUserFields(uids, ['uid', 'username', 'userslug', 'picture', 'status', 'banned', 'postcount', 'reputation'], next);
},
isAdmin: function(next) {
User.isAdministrator(uids, next);
},
isOnline: function(next) {
db.isSortedSetMembers('users:online', uids, next);
}
async.waterfall([
function(next) {
User.isAdministrator(user.uid, next);
},
function(isAdmin, next) {
user.status = !user.status ? 'online' : user.status;
user.administrator = isAdmin;
user.banned = parseInt(user.banned, 10) === 1;
db.isSortedSetMember('users:online', user.uid, next);
},
function(isMember, next) {
if (!isMember) {
user.status = 'offline';
}
next(null, user);
}
], callback);
}
User.getMultipleUserFields(uids, ['uid', 'username', 'userslug', 'picture', 'status', 'banned', 'postcount', 'reputation'], function(err, usersData) {
}, function(err, results) {
if (err) {
return callback(err);
}
async.map(usersData, loadUserInfo, callback);
results.userData.forEach(function(user, index) {
if (!user) {
return;
}
user.status = !user.status ? 'online' : user.status;
user.status = !results.isOnline[index] ? 'offline' : user.status;
user.administrator = results.isAdmin[index];
user.banned = parseInt(user.banned, 10) === 1;
});
callback(err, results.userData);
});
};
@@ -410,7 +406,11 @@ var bcrypt = require('bcryptjs'),
};
User.isAdministrator = function(uid, callback) {
groups.isMember(uid, 'administrators', callback);
if (Array.isArray(uid)) {
groups.isMembers(uid, 'administrators', callback);
} else {
groups.isMember(uid, 'administrators', callback);
}
};
User.isOnline = function(uid, callback) {