Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 08:36:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: reverse uid checks

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2020-07-29 11:48:32 -04:00
parent 303bffdb5f
commit 7331faed9f
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/groups/membership.js
View File

@@ -4,7 +4,6 @@ const _ = require('lodash');
const db = require('../database');
const user = require('../user');
const cache = require('../cache');
module.exports = function (Groups) {
@@ -25,7 +24,7 @@ module.exports = function (Groups) {
};
Groups.isMember = async function (uid, groupName) {
if (!uid || parseInt(uid, 10) <= 0 || !groupName) {
if (!uid || !(parseInt(uid, 10) > 0) || !groupName) {
return false;
}
@@ -66,7 +65,7 @@ module.exports = function (Groups) {
};
Groups.isMemberOfGroups = async function (uid, groups) {
if (!uid || parseInt(uid, 10) <= 0 || !groups.length) {
if (!uid || !(parseInt(uid, 10) > 0) || !groups.length) {
return groups.map(groupName => groupName === 'guests');
}
const cachedData = {};