Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-16 18:56:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

perf: increase batch size for notifs, run parallel

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2021-03-26 17:47:57 -04:00
parent 24236718d5
commit 728ac5ff72
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/notifications.js
View File

@@ -148,7 +148,7 @@ Notifications.push = async function (notification, uids) {
setTimeout(() => { setTimeout(() => {
batch.processArray(uids, async (uids) => { batch.processArray(uids, async (uids) => {
await pushToUids(uids, notification); await pushToUids(uids, notification);
}, { interval: 1000 }, (err) => { }, { interval: 1000, batch: 500 }, (err) => {
if (err) { if (err) {
winston.error(err.stack); winston.error(err.stack);
} }
@@ -164,8 +164,10 @@ async function pushToUids(uids, notification) {
const cutoff = Date.now() - notificationPruneCutoff; const cutoff = Date.now() - notificationPruneCutoff;
const unreadKeys = uids.map(uid => `uid:${uid}:notifications:unread`); const unreadKeys = uids.map(uid => `uid:${uid}:notifications:unread`);
const readKeys = uids.map(uid => `uid:${uid}:notifications:read`); const readKeys = uids.map(uid => `uid:${uid}:notifications:read`);
await db.sortedSetsAdd(unreadKeys, notification.datetime, notification.nid); await Promise.all([
await db.sortedSetsRemove(readKeys, notification.nid); db.sortedSetsAdd(unreadKeys, notification.datetime, notification.nid),
db.sortedSetsRemove(readKeys, notification.nid),
]);
await db.sortedSetsRemoveRangeByScore(unreadKeys.concat(readKeys), '-inf', cutoff); await db.sortedSetsRemoveRangeByScore(unreadKeys.concat(readKeys), '-inf', cutoff);
const websockets = require('./socket.io'); const websockets = require('./socket.io');
if (websockets.server) { if (websockets.server) {