Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-30 10:35:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

chore: eslint prefer-template

Browse Source
This commit is contained in:
Peter Jaszkowiak
2021-02-03 23:59:08 -07:00
committed by Julian Lam
parent 4ee0f1459d
commit 707b55b6a5
357 changed files with 2425 additions and 2427 deletions
Download Patch File Download Diff File Expand all files Collapse all files

112
test/controllers-admin.js
View File

@@ -69,7 +69,7 @@ describe('Admin Controllers', function () {
helpers.loginUser('admin', 'barbar', function (err, _jar) {
assert.ifError(err);
jar = _jar;
request(nconf.get('url') + '/admin', { jar: jar }, function (err, res, body) {
request(`${nconf.get('url')}/admin`, { jar: jar }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 403);
assert(body);
@@ -81,7 +81,7 @@ describe('Admin Controllers', function () {
it('should load admin dashboard', function (done) {
groups.join('administrators', adminUid, function (err) {
assert.ifError(err);
request(nconf.get('url') + '/admin', { jar: jar }, function (err, res, body) {
request(`${nconf.get('url')}/admin`, { jar: jar }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -91,7 +91,7 @@ describe('Admin Controllers', function () {
});
it('should load groups page', function (done) {
request(nconf.get('url') + '/admin/manage/groups', { jar: jar }, function (err, res, body) {
request(`${nconf.get('url')}/admin/manage/groups`, { jar: jar }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -100,7 +100,7 @@ describe('Admin Controllers', function () {
});
it('should load groups detail page', function (done) {
request(nconf.get('url') + '/admin/manage/groups/administrators', { jar: jar }, function (err, res, body) {
request(`${nconf.get('url')}/admin/manage/groups/administrators`, { jar: jar }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -109,7 +109,7 @@ describe('Admin Controllers', function () {
});
it('should load global privileges page', function (done) {
request(nconf.get('url') + '/admin/manage/privileges', { jar: jar }, function (err, res, body) {
request(`${nconf.get('url')}/admin/manage/privileges`, { jar: jar }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -118,7 +118,7 @@ describe('Admin Controllers', function () {
});
it('should load privileges page for category 1', function (done) {
request(nconf.get('url') + '/admin/manage/privileges/1', { jar: jar }, function (err, res, body) {
request(`${nconf.get('url')}/admin/manage/privileges/1`, { jar: jar }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -127,7 +127,7 @@ describe('Admin Controllers', function () {
});
it('should load manage uploads', function (done) {
request(nconf.get('url') + '/admin/manage/uploads', { jar: jar }, function (err, res, body) {
request(`${nconf.get('url')}/admin/manage/uploads`, { jar: jar }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -136,7 +136,7 @@ describe('Admin Controllers', function () {
});
it('should load general settings page', function (done) {
request(nconf.get('url') + '/admin/settings', { jar: jar }, function (err, res, body) {
request(`${nconf.get('url')}/admin/settings`, { jar: jar }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -145,7 +145,7 @@ describe('Admin Controllers', function () {
});
it('should load email settings page', function (done) {
request(nconf.get('url') + '/admin/settings/email', { jar: jar }, function (err, res, body) {
request(`${nconf.get('url')}/admin/settings/email`, { jar: jar }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -154,7 +154,7 @@ describe('Admin Controllers', function () {
});
it('should load user settings page', function (done) {
request(nconf.get('url') + '/admin/settings/user', { jar: jar }, function (err, res, body) {
request(`${nconf.get('url')}/admin/settings/user`, { jar: jar }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -163,7 +163,7 @@ describe('Admin Controllers', function () {
});
it('should load info page for a user', function (done) {
request(nconf.get('url') + '/api/user/regular/info', { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/user/regular/info`, { jar: jar, json: true }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body.history);
@@ -175,7 +175,7 @@ describe('Admin Controllers', function () {
});
it('should 404 for edit/email page if user does not exist', function (done) {
request(nconf.get('url') + '/api/user/doesnotexist/edit/email', { jar: jar, json: true }, function (err, res) {
request(`${nconf.get('url')}/api/user/doesnotexist/edit/email`, { jar: jar, json: true }, function (err, res) {
assert.ifError(err);
assert.equal(res.statusCode, 404);
done();
@@ -183,7 +183,7 @@ describe('Admin Controllers', function () {
});
it('should load /admin/settings/homepage', function (done) {
request(nconf.get('url') + '/api/admin/settings/homepage', { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/settings/homepage`, { jar: jar, json: true }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body.routes);
@@ -192,7 +192,7 @@ describe('Admin Controllers', function () {
});
it('should load /admin/advanced/database', function (done) {
request(nconf.get('url') + '/api/admin/advanced/database', { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/advanced/database`, { jar: jar, json: true }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
@@ -208,7 +208,7 @@ describe('Admin Controllers', function () {
});
it('should load /admin/extend/plugins', function (done) {
request(nconf.get('url') + '/api/admin/extend/plugins', { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/extend/plugins`, { jar: jar, json: true }, function (err, res, body) {
assert.ifError(err);
assert(body.hasOwnProperty('installed'));
assert(body.hasOwnProperty('upgradeCount'));
@@ -219,7 +219,7 @@ describe('Admin Controllers', function () {
});
it('should load /admin/manage/users', function (done) {
request(nconf.get('url') + '/api/admin/manage/users', { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/manage/users`, { jar: jar, json: true }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -228,7 +228,7 @@ describe('Admin Controllers', function () {
});
it('should load /admin/manage/registration', function (done) {
request(nconf.get('url') + '/api/admin/manage/registration', { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/manage/registration`, { jar: jar, json: true }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -237,7 +237,7 @@ describe('Admin Controllers', function () {
});
it('should 404 if users is not privileged', function (done) {
request(nconf.get('url') + '/api/registration-queue', { json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/registration-queue`, { json: true }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 404);
assert(body);
@@ -246,7 +246,7 @@ describe('Admin Controllers', function () {
});
it('should load /api/registration-queue', function (done) {
request(nconf.get('url') + '/api/registration-queue', { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/registration-queue`, { jar: jar, json: true }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -255,7 +255,7 @@ describe('Admin Controllers', function () {
});
it('should load /admin/manage/admins-mods', function (done) {
request(nconf.get('url') + '/api/admin/manage/admins-mods', { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/manage/admins-mods`, { jar: jar, json: true }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -268,10 +268,10 @@ describe('Admin Controllers', function () {
socketAdmin.user.exportUsersCSV({ uid: adminUid }, {}, function (err) {
assert.ifError(err);
setTimeout(function () {
request(nconf.get('url') + '/api/admin/users/csv', {
request(`${nconf.get('url')}/api/admin/users/csv`, {
jar: jar,
headers: {
referer: nconf.get('url') + '/admin/manage/users',
referer: `${nconf.get('url')}/admin/manage/users`,
},
}, function (err, res, body) {
assert.ifError(err);
@@ -284,7 +284,7 @@ describe('Admin Controllers', function () {
});
it('should return 403 if no referer', function (done) {
request(nconf.get('url') + '/api/admin/groups/administrators/csv', { jar: jar }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/groups/administrators/csv`, { jar: jar }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 403);
assert.equal(body, '[[error:invalid-origin]]');
@@ -293,7 +293,7 @@ describe('Admin Controllers', function () {
});
it('should return 403 if referer is not /api/admin/groups/administrators/csv', function (done) {
request(nconf.get('url') + '/api/admin/groups/administrators/csv', {
request(`${nconf.get('url')}/api/admin/groups/administrators/csv`, {
jar: jar,
headers: {
referer: '/topic/1/test',
@@ -307,10 +307,10 @@ describe('Admin Controllers', function () {
});
it('should load /api/admin/groups/administrators/csv', function (done) {
request(nconf.get('url') + '/api/admin/groups/administrators/csv', {
request(`${nconf.get('url')}/api/admin/groups/administrators/csv`, {
jar: jar,
headers: {
referer: nconf.get('url') + '/admin/manage/groups',
referer: `${nconf.get('url')}/admin/manage/groups`,
},
}, function (err, res, body) {
assert.ifError(err);
@@ -321,7 +321,7 @@ describe('Admin Controllers', function () {
});
it('should load /admin/advanced/hooks', function (done) {
request(nconf.get('url') + '/api/admin/advanced/hooks', { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/advanced/hooks`, { jar: jar, json: true }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -330,7 +330,7 @@ describe('Admin Controllers', function () {
});
it('should load /admin/advanced/cache', function (done) {
request(nconf.get('url') + '/api/admin/advanced/cache', { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/advanced/cache`, { jar: jar, json: true }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -339,7 +339,7 @@ describe('Admin Controllers', function () {
});
it('should load /admin/advanced/errors', function (done) {
request(nconf.get('url') + '/api/admin/advanced/errors', { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/advanced/errors`, { jar: jar, json: true }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -350,7 +350,7 @@ describe('Admin Controllers', function () {
it('should load /admin/advanced/errors/export', function (done) {
meta.errors.clear(function (err) {
assert.ifError(err);
request(nconf.get('url') + '/api/admin/advanced/errors/export', { jar: jar }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/advanced/errors/export`, { jar: jar }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert.strictEqual(body, '');
@@ -363,7 +363,7 @@ describe('Admin Controllers', function () {
var fs = require('fs');
fs.appendFile(meta.logs.path, 'dummy log', function (err) {
assert.ifError(err);
request(nconf.get('url') + '/api/admin/advanced/logs', { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/advanced/logs`, { jar: jar, json: true }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -378,7 +378,7 @@ describe('Admin Controllers', function () {
navigation.save(data, function (err) {
assert.ifError(err);
request(nconf.get('url') + '/api/admin/settings/navigation', { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/settings/navigation`, { jar: jar, json: true }, function (err, res, body) {
assert.ifError(err);
assert(body);
assert(body.available);
@@ -389,7 +389,7 @@ describe('Admin Controllers', function () {
});
it('should load /admin/development/info', function (done) {
request(nconf.get('url') + '/api/admin/development/info', { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/development/info`, { jar: jar, json: true }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -398,7 +398,7 @@ describe('Admin Controllers', function () {
});
it('should load /admin/development/logger', function (done) {
request(nconf.get('url') + '/api/admin/development/logger', { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/development/logger`, { jar: jar, json: true }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -407,7 +407,7 @@ describe('Admin Controllers', function () {
});
it('should load /admin/advanced/events', function (done) {
request(nconf.get('url') + '/api/admin/advanced/events', { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/advanced/events`, { jar: jar, json: true }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -416,7 +416,7 @@ describe('Admin Controllers', function () {
});
it('should load /admin/manage/categories', function (done) {
request(nconf.get('url') + '/api/admin/manage/categories', { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/manage/categories`, { jar: jar, json: true }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -425,7 +425,7 @@ describe('Admin Controllers', function () {
});
it('should load /admin/manage/categories/1', function (done) {
request(nconf.get('url') + '/api/admin/manage/categories/1', { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/manage/categories/1`, { jar: jar, json: true }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -434,7 +434,7 @@ describe('Admin Controllers', function () {
});
it('should load /admin/manage/categories/1/analytics', function (done) {
request(nconf.get('url') + '/api/admin/manage/categories/1/analytics', { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/manage/categories/1/analytics`, { jar: jar, json: true }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -443,7 +443,7 @@ describe('Admin Controllers', function () {
});
it('should load /admin/extend/rewards', function (done) {
request(nconf.get('url') + '/api/admin/extend/rewards', { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/extend/rewards`, { jar: jar, json: true }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -452,7 +452,7 @@ describe('Admin Controllers', function () {
});
it('should load /admin/extend/widgets', function (done) {
request(nconf.get('url') + '/api/admin/extend/widgets', { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/extend/widgets`, { jar: jar, json: true }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -461,7 +461,7 @@ describe('Admin Controllers', function () {
});
it('should load /admin/settings/languages', function (done) {
request(nconf.get('url') + '/api/admin/settings/languages', { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/settings/languages`, { jar: jar, json: true }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -473,7 +473,7 @@ describe('Admin Controllers', function () {
var socketAdmin = require('../src/socket.io/admin');
socketAdmin.social.savePostSharingNetworks({ uid: adminUid }, ['facebook', 'twitter'], function (err) {
assert.ifError(err);
request(nconf.get('url') + '/api/admin/settings/social', { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/settings/social`, { jar: jar, json: true }, function (err, res, body) {
assert.ifError(err);
assert(body);
body = body.posts.map(function (network) {
@@ -487,7 +487,7 @@ describe('Admin Controllers', function () {
});
it('should load /admin/manage/tags', function (done) {
request(nconf.get('url') + '/api/admin/manage/tags', { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/manage/tags`, { jar: jar, json: true }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -496,7 +496,7 @@ describe('Admin Controllers', function () {
});
it('/post-queue should 404 for regular user', function (done) {
request(nconf.get('url') + '/api/post-queue', { json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/post-queue`, { json: true }, function (err, res, body) {
assert.ifError(err);
assert(body);
assert.equal(res.statusCode, 404);
@@ -505,7 +505,7 @@ describe('Admin Controllers', function () {
});
it('should load /post-queue', function (done) {
request(nconf.get('url') + '/api/post-queue', { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/post-queue`, { jar: jar, json: true }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -514,7 +514,7 @@ describe('Admin Controllers', function () {
});
it('/ip-blacklist should 404 for regular user', function (done) {
request(nconf.get('url') + '/api/ip-blacklist', { json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/ip-blacklist`, { json: true }, function (err, res, body) {
assert.ifError(err);
assert(body);
assert.equal(res.statusCode, 404);
@@ -523,7 +523,7 @@ describe('Admin Controllers', function () {
});
it('should load /ip-blacklist', function (done) {
request(nconf.get('url') + '/api/ip-blacklist', { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/ip-blacklist`, { jar: jar, json: true }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -532,7 +532,7 @@ describe('Admin Controllers', function () {
});
it('should load /admin/appearance/themes', function (done) {
request(nconf.get('url') + '/api/admin/appearance/themes', { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/appearance/themes`, { jar: jar, json: true }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -541,7 +541,7 @@ describe('Admin Controllers', function () {
});
it('should load /admin/appearance/customise', function (done) {
request(nconf.get('url') + '/api/admin/appearance/customise', { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/admin/appearance/customise`, { jar: jar, json: true }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -551,7 +551,7 @@ describe('Admin Controllers', function () {
it('should load /recent in maintenance mode', function (done) {
meta.config.maintenanceMode = 1;
request(nconf.get('url') + '/api/recent', { jar: jar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/recent`, { jar: jar, json: true }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
@@ -568,12 +568,12 @@ describe('Admin Controllers', function () {
assert.ifError(err);
moderatorJar = _jar;
groups.join('cid:' + cid + ':privileges:moderate', moderatorUid, done);
groups.join(`cid:${cid}:privileges:moderate`, moderatorUid, done);
});
});
it('should error with no privileges', function (done) {
request(nconf.get('url') + '/api/flags', { json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/flags`, { json: true }, function (err, res, body) {
assert.ifError(err);
assert.equal(body.error, '[[error:no-privileges]]');
done();
@@ -581,7 +581,7 @@ describe('Admin Controllers', function () {
});
it('should load flags page data', function (done) {
request(nconf.get('url') + '/api/flags', { jar: moderatorJar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/flags`, { jar: moderatorJar, json: true }, function (err, res, body) {
assert.ifError(err);
assert(body);
assert(body.flags);
@@ -592,7 +592,7 @@ describe('Admin Controllers', function () {
});
it('should return invalid data if flag does not exist', function (done) {
request(nconf.get('url') + '/api/flags/123123123', { jar: moderatorJar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/flags/123123123`, { jar: moderatorJar, json: true }, function (err, res, body) {
assert.ifError(err);
assert.equal(body.error, '[[error:invalid-data]]');
done();
@@ -627,7 +627,7 @@ describe('Admin Controllers', function () {
socketFlags.create({ uid: regularUid }, { id: regularPid, type: 'post', reason: 'spam' }, function (err, flagId) {
meta.config['min:rep:flag'] = oldValue;
assert.ifError(err);
request(nconf.get('url') + '/api/flags/' + flagId, { jar: moderatorJar, json: true }, function (err, res, body) {
request(`${nconf.get('url')}/api/flags/${flagId}`, { jar: moderatorJar, json: true }, function (err, res, body) {
assert.ifError(err);
assert(body);
assert(body.reports);
@@ -648,7 +648,7 @@ describe('Admin Controllers', function () {
callback(null, config);
}
plugins.hooks.register('somePlugin', { hook: 'filter:config.get', method: onConfigGet });
request(nconf.get('url') + '/admin', { jar: jar }, function (err, res, body) {
request(`${nconf.get('url')}/admin`, { jar: jar }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);