Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: check if latestversion is valid before using semver.gt

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2025-03-19 21:03:08 -04:00
parent c258f597c5
commit 6fe066ced2
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/controllers/admin/dashboard.js
View File

@@ -28,12 +28,13 @@ dashboardController.get = async function (req, res) {
getPopularSearches(), getPopularSearches(),
]); ]);
const version = nconf.get('version'); const version = nconf.get('version');
const latestValidVersion = semver.valid(latestVersion);
res.render('admin/dashboard', { res.render('admin/dashboard', {
version: version, version: version,
lookupFailed: latestVersion === null, lookupFailed: latestValidVersion === null,
latestVersion: latestVersion, latestVersion: latestValidVersion,
upgradeAvailable: latestVersion && semver.gt(latestVersion, version), upgradeAvailable: latestValidVersion && semver.gt(latestValidVersion, version),
currentPrerelease: versions.isPrerelease.test(version), currentPrerelease: versions.isPrerelease.test(version),
notices: notices, notices: notices,
stats: stats, stats: stats,