mirror of
https://github.com/NodeBB/NodeBB.git
synced 2025-12-20 23:40:38 +01:00
refactor: async/await admin/controllers
This commit is contained in:
Barış Soner Uşaklı
@@ -1,18 +1,18 @@
|
||||
'use strict';
|
||||
|
||||
var async = require('async');
|
||||
var nconf = require('nconf');
|
||||
const nconf = require('nconf');
|
||||
|
||||
var user = require('../../user');
|
||||
var meta = require('../../meta');
|
||||
var db = require('../../database');
|
||||
var pagination = require('../../pagination');
|
||||
var events = require('../../events');
|
||||
var plugins = require('../../plugins');
|
||||
const user = require('../../user');
|
||||
const meta = require('../../meta');
|
||||
const db = require('../../database');
|
||||
const pagination = require('../../pagination');
|
||||
const events = require('../../events');
|
||||
const plugins = require('../../plugins');
|
||||
const utils = require('../../utils');
|
||||
|
||||
var usersController = module.exports;
|
||||
const usersController = module.exports;
|
||||
|
||||
var userFields = ['uid', 'username', 'userslug', 'email', 'postcount', 'joindate', 'banned',
|
||||
const userFields = ['uid', 'username', 'userslug', 'email', 'postcount', 'joindate', 'banned',
|
||||
'reputation', 'picture', 'flags', 'lastonline', 'email:confirmed'];
|
||||
|
||||
usersController.search = function (req, res) {
|
||||
@@ -22,154 +22,129 @@ usersController.search = function (req, res) {
|
||||
});
|
||||
};
|
||||
|
||||
usersController.sortByJoinDate = function (req, res, next) {
|
||||
getUsers('users:joindate', 'latest', undefined, undefined, req, res, next);
|
||||
usersController.sortByJoinDate = async function (req, res) {
|
||||
await getUsers('users:joindate', 'latest', undefined, undefined, req, res);
|
||||
};
|
||||
|
||||
usersController.notValidated = function (req, res, next) {
|
||||
getUsers('users:notvalidated', 'notvalidated', undefined, undefined, req, res, next);
|
||||
usersController.notValidated = async function (req, res) {
|
||||
await getUsers('users:notvalidated', 'notvalidated', undefined, undefined, req, res);
|
||||
};
|
||||
|
||||
usersController.noPosts = function (req, res, next) {
|
||||
getUsers('users:postcount', 'noposts', '-inf', 0, req, res, next);
|
||||
usersController.noPosts = async function (req, res) {
|
||||
await getUsers('users:postcount', 'noposts', '-inf', 0, req, res);
|
||||
};
|
||||
|
||||
usersController.topPosters = function (req, res, next) {
|
||||
getUsers('users:postcount', 'topposts', 0, '+inf', req, res, next);
|
||||
usersController.topPosters = async function (req, res) {
|
||||
await getUsers('users:postcount', 'topposts', 0, '+inf', req, res);
|
||||
};
|
||||
|
||||
usersController.mostReputaion = function (req, res, next) {
|
||||
getUsers('users:reputation', 'mostreputation', 0, '+inf', req, res, next);
|
||||
usersController.mostReputaion = async function (req, res) {
|
||||
await getUsers('users:reputation', 'mostreputation', 0, '+inf', req, res);
|
||||
};
|
||||
|
||||
usersController.flagged = function (req, res, next) {
|
||||
getUsers('users:flags', 'mostflags', 1, '+inf', req, res, next);
|
||||
usersController.flagged = async function (req, res) {
|
||||
await getUsers('users:flags', 'mostflags', 1, '+inf', req, res);
|
||||
};
|
||||
|
||||
usersController.inactive = function (req, res, next) {
|
||||
var timeRange = 1000 * 60 * 60 * 24 * 30 * (parseInt(req.query.months, 10) || 3);
|
||||
var cutoff = Date.now() - timeRange;
|
||||
getUsers('users:online', 'inactive', '-inf', cutoff, req, res, next);
|
||||
usersController.inactive = async function (req, res) {
|
||||
const timeRange = 1000 * 60 * 60 * 24 * 30 * (parseInt(req.query.months, 10) || 3);
|
||||
const cutoff = Date.now() - timeRange;
|
||||
await getUsers('users:online', 'inactive', '-inf', cutoff, req, res);
|
||||
};
|
||||
|
||||
usersController.banned = function (req, res, next) {
|
||||
getUsers('users:banned', 'banned', undefined, undefined, req, res, next);
|
||||
usersController.banned = async function (req, res) {
|
||||
await getUsers('users:banned', 'banned', undefined, undefined, req, res);
|
||||
};
|
||||
|
||||
usersController.registrationQueue = function (req, res, next) {
|
||||
var page = parseInt(req.query.page, 10) || 1;
|
||||
var itemsPerPage = 20;
|
||||
var start = (page - 1) * 20;
|
||||
var stop = start + itemsPerPage - 1;
|
||||
var invitations;
|
||||
usersController.registrationQueue = async function (req, res) {
|
||||
const page = parseInt(req.query.page, 10) || 1;
|
||||
const itemsPerPage = 20;
|
||||
const start = (page - 1) * 20;
|
||||
const stop = start + itemsPerPage - 1;
|
||||
|
||||
async.waterfall([
|
||||
function (next) {
|
||||
async.parallel({
|
||||
registrationQueueCount: function (next) {
|
||||
db.sortedSetCard('registration:queue', next);
|
||||
},
|
||||
users: function (next) {
|
||||
user.getRegistrationQueue(start, stop, next);
|
||||
},
|
||||
customHeaders: function (next) {
|
||||
plugins.fireHook('filter:admin.registrationQueue.customHeaders', { headers: [] }, next);
|
||||
},
|
||||
invites: function (next) {
|
||||
async.waterfall([
|
||||
function (next) {
|
||||
user.getAllInvites(next);
|
||||
},
|
||||
function (_invitations, next) {
|
||||
invitations = _invitations;
|
||||
async.map(invitations, function (invites, next) {
|
||||
user.getUserField(invites.uid, 'username', next);
|
||||
}, next);
|
||||
},
|
||||
function (usernames, next) {
|
||||
invitations.forEach(function (invites, index) {
|
||||
invites.username = usernames[index];
|
||||
});
|
||||
async.map(invitations, function (invites, next) {
|
||||
async.map(invites.invitations, user.getUsernameByEmail, next);
|
||||
}, next);
|
||||
},
|
||||
function (usernames, next) {
|
||||
invitations.forEach(function (invites, index) {
|
||||
invites.invitations = invites.invitations.map(function (email, i) {
|
||||
return {
|
||||
email: email,
|
||||
username: usernames[index][i] === '[[global:guest]]' ? '' : usernames[index][i],
|
||||
};
|
||||
});
|
||||
});
|
||||
next(null, invitations);
|
||||
},
|
||||
], next);
|
||||
},
|
||||
}, next);
|
||||
},
|
||||
function (data) {
|
||||
var pageCount = Math.max(1, Math.ceil(data.registrationQueueCount / itemsPerPage));
|
||||
data.pagination = pagination.create(page, pageCount);
|
||||
data.customHeaders = data.customHeaders.headers;
|
||||
res.render('admin/manage/registration', data);
|
||||
},
|
||||
], next);
|
||||
const data = await utils.promiseParallel({
|
||||
registrationQueueCount: db.sortedSetCard('registration:queue'),
|
||||
users: user.getRegistrationQueue(start, stop),
|
||||
customHeaders: plugins.fireHook('filter:admin.registrationQueue.customHeaders', { headers: [] }),
|
||||
invites: getInvites(),
|
||||
});
|
||||
var pageCount = Math.max(1, Math.ceil(data.registrationQueueCount / itemsPerPage));
|
||||
data.pagination = pagination.create(page, pageCount);
|
||||
data.customHeaders = data.customHeaders.headers;
|
||||
res.render('admin/manage/registration', data);
|
||||
};
|
||||
|
||||
function getUsers(set, section, min, max, req, res, next) {
|
||||
var page = parseInt(req.query.page, 10) || 1;
|
||||
var resultsPerPage = parseInt(req.query.resultsPerPage, 10) || 50;
|
||||
async function getInvites() {
|
||||
const invitations = await user.getAllInvites();
|
||||
const uids = invitations.map(invite => invite.uid);
|
||||
let usernames = await user.getUsersFields(uids, ['username']);
|
||||
usernames = usernames.map(user => user.username);
|
||||
|
||||
invitations.forEach(function (invites, index) {
|
||||
invites.username = usernames[index];
|
||||
});
|
||||
|
||||
async function getUsernamesByEmails(emails) {
|
||||
const uids = await db.sortedSetScore('email:uid', emails.map(email => String(email).toLowerCase()));
|
||||
const usernames = await user.getUsersFields(uids, ['username']);
|
||||
return usernames.map(user => user.username);
|
||||
}
|
||||
|
||||
usernames = await Promise.all(invitations.map(invites => getUsernamesByEmails(invites.invitations)));
|
||||
|
||||
invitations.forEach(function (invites, index) {
|
||||
invites.invitations = invites.invitations.map(function (email, i) {
|
||||
return {
|
||||
email: email,
|
||||
username: usernames[index][i] === '[[global:guest]]' ? '' : usernames[index][i],
|
||||
};
|
||||
});
|
||||
});
|
||||
return invitations;
|
||||
}
|
||||
|
||||
async function getUsers(set, section, min, max, req, res) {
|
||||
const page = parseInt(req.query.page, 10) || 1;
|
||||
let resultsPerPage = parseInt(req.query.resultsPerPage, 10) || 50;
|
||||
if (![50, 100, 250, 500].includes(resultsPerPage)) {
|
||||
resultsPerPage = 50;
|
||||
}
|
||||
var start = Math.max(0, page - 1) * resultsPerPage;
|
||||
var stop = start + resultsPerPage - 1;
|
||||
var byScore = min !== undefined && max !== undefined;
|
||||
const start = Math.max(0, page - 1) * resultsPerPage;
|
||||
const stop = start + resultsPerPage - 1;
|
||||
const byScore = min !== undefined && max !== undefined;
|
||||
|
||||
async.waterfall([
|
||||
function (next) {
|
||||
async.parallel({
|
||||
count: function (next) {
|
||||
if (byScore) {
|
||||
db.sortedSetCount(set, min, max, next);
|
||||
} else if (set === 'users:banned' || set === 'users:notvalidated') {
|
||||
db.sortedSetCard(set, next);
|
||||
} else {
|
||||
db.getObjectField('global', 'userCount', next);
|
||||
}
|
||||
},
|
||||
users: function (next) {
|
||||
async.waterfall([
|
||||
function (next) {
|
||||
if (byScore) {
|
||||
db.getSortedSetRevRangeByScore(set, start, resultsPerPage, max, min, next);
|
||||
} else {
|
||||
user.getUidsFromSet(set, start, stop, next);
|
||||
}
|
||||
},
|
||||
function (uids, next) {
|
||||
user.getUsersWithFields(uids, userFields, req.uid, next);
|
||||
},
|
||||
], next);
|
||||
},
|
||||
}, next);
|
||||
},
|
||||
function (results) {
|
||||
results.users = results.users.filter(function (user) {
|
||||
return user && parseInt(user.uid, 10);
|
||||
});
|
||||
var data = {
|
||||
users: results.users,
|
||||
page: page,
|
||||
pageCount: Math.max(1, Math.ceil(results.count / resultsPerPage)),
|
||||
resultsPerPage: resultsPerPage,
|
||||
};
|
||||
data[section] = true;
|
||||
render(req, res, data);
|
||||
},
|
||||
], next);
|
||||
async function getCount() {
|
||||
if (byScore) {
|
||||
return await db.sortedSetCount(set, min, max);
|
||||
} else if (set === 'users:banned' || set === 'users:notvalidated') {
|
||||
return await db.sortedSetCard(set);
|
||||
}
|
||||
return await db.getObjectField('global', 'userCount');
|
||||
}
|
||||
|
||||
async function getUsersWithFields() {
|
||||
let uids;
|
||||
if (byScore) {
|
||||
uids = await db.getSortedSetRevRangeByScore(set, start, resultsPerPage, max, min);
|
||||
} else {
|
||||
uids = await user.getUidsFromSet(set, start, stop);
|
||||
}
|
||||
return await user.getUsersWithFields(uids, userFields, req.uid);
|
||||
}
|
||||
|
||||
const [count, users] = await Promise.all([
|
||||
getCount(),
|
||||
getUsersWithFields(),
|
||||
]);
|
||||
|
||||
const data = {
|
||||
users: users.filter(user => user && parseInt(user.uid, 10)),
|
||||
page: page,
|
||||
pageCount: Math.max(1, Math.ceil(count / resultsPerPage)),
|
||||
resultsPerPage: resultsPerPage,
|
||||
};
|
||||
data[section] = true;
|
||||
render(req, res, data);
|
||||
}
|
||||
|
||||
function render(req, res, data) {
|
||||
@@ -185,7 +160,7 @@ function render(req, res, data) {
|
||||
res.render('admin/manage/users', data);
|
||||
}
|
||||
|
||||
usersController.getCSV = function (req, res, next) {
|
||||
usersController.getCSV = async function (req, res) {
|
||||
var referer = req.headers.referer;
|
||||
|
||||
if (!referer || !referer.replace(nconf.get('url'), '').startsWith('/admin/manage/users')) {
|
||||
@@ -196,14 +171,8 @@ usersController.getCSV = function (req, res, next) {
|
||||
uid: req.uid,
|
||||
ip: req.ip,
|
||||
});
|
||||
async.waterfall([
|
||||
function (next) {
|
||||
user.getUsersCSV(next);
|
||||
},
|
||||
function (data) {
|
||||
res.attachment('users.csv');
|
||||
res.setHeader('Content-Type', 'text/csv');
|
||||
res.end(data);
|
||||
},
|
||||
], next);
|
||||
const data = await user.getUsersCSV();
|
||||
res.attachment('users.csv');
|
||||
res.setHeader('Content-Type', 'text/csv');
|
||||
res.end(data);
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user