Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-28 09:36:16 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: #11438, show flag history to mods

Browse Source 
also prevent regular mods from seeing flags that are not in their category if they use direct link to flag
This commit is contained in:
Barış Soner Uşaklı
2023-04-11 15:38:53 -04:00
parent 70f4d7f099
commit 6eb1dd8687
1 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/controllers/mods.js
View File

@@ -6,6 +6,7 @@ const user = require('../user');
const groups = require('../groups'); const groups = require('../groups');
const meta = require('../meta'); const meta = require('../meta');
const posts = require('../posts'); const posts = require('../posts');
const db = require('../database');
const flags = require('../flags'); const flags = require('../flags');
const analytics = require('../analytics'); const analytics = require('../analytics');
const plugins = require('../plugins'); const plugins = require('../plugins');
@@ -134,11 +135,27 @@ modsController.flags.detail = async function (req, res, next) {
privileges: Promise.all(['global', 'admin'].map(async type => privileges[type].get(req.uid))), privileges: Promise.all(['global', 'admin'].map(async type => privileges[type].get(req.uid))),
}); });
results.privileges = { ...results.privileges[0], ...results.privileges[1] }; results.privileges = { ...results.privileges[0], ...results.privileges[1] };
if (!results.flagData || (!(results.isAdminOrGlobalMod || !!results.moderatedCids.length))) { if (!results.flagData || (!(results.isAdminOrGlobalMod || !!results.moderatedCids.length))) {
return next(); // 404 return next(); // 404
} }
// extra checks for plain moderators
if (!results.isAdminOrGlobalMod) {
if (results.flagData.type === 'user') {
return next();
}
if (results.flagData.type === 'post') {
const isFlagInModeratedCids = await db.isMemberOfSortedSets(
results.moderatedCids.map(cid => `flags:byCid:${cid}`),
results.flagData.flagId
);
if (!isFlagInModeratedCids.includes(true)) {
return next();
}
}
}
async function getAssignees(flagData) { async function getAssignees(flagData) {
let uids = []; let uids = [];
const [admins, globalMods] = await Promise.all([ const [admins, globalMods] = await Promise.all([
@@ -161,7 +178,7 @@ modsController.flags.detail = async function (req, res, next) {
} }
const assignees = await getAssignees(results.flagData); const assignees = await getAssignees(results.flagData);
results.flagData.history = results.isAdminOrGlobalMod ? (await flags.getHistory(req.params.flagId)) : null; results.flagData.history = await flags.getHistory(req.params.flagId);
if (results.flagData.type === 'user') { if (results.flagData.type === 'user') {
results.flagData.type_path = 'uid'; results.flagData.type_path = 'uid';