Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 08:36:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: closes #12795, don't crash if there is an error in auto approve from queue

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2024-09-14 18:39:22 -04:00
parent c9cadbad7e
commit 6ccf40bf6f
1 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/user/approval.js
View File

@@ -14,8 +14,12 @@ const slugify = require('../slugify');
const plugins = require('../plugins'); const plugins = require('../plugins');
module.exports = function (User) { module.exports = function (User) {
new cronJob('0 * * * *', (() => { new cronJob('0 * * * *', (async () => {
User.autoApprove(); try {
await User.autoApprove();
} catch (err) {
winston.error(err.stack);
}
}), null, true); }), null, true);
User.addToApprovalQueue = async function (userData) { User.addToApprovalQueue = async function (userData) {
@@ -160,8 +164,14 @@ module.exports = function (User) {
const users = await db.getSortedSetRevRangeWithScores('registration:queue', 0, -1); const users = await db.getSortedSetRevRangeWithScores('registration:queue', 0, -1);
const now = Date.now(); const now = Date.now();
for (const user of users.filter(user => now - user.score >= meta.config.autoApproveTime * 3600000)) { for (const user of users.filter(user => now - user.score >= meta.config.autoApproveTime * 3600000)) {
// eslint-disable-next-line no-await-in-loop try {
await User.acceptRegistration(user.value); // eslint-disable-next-line no-await-in-loop
await User.acceptRegistration(user.value);
} catch (err) {
winston.error(err.stack);
// eslint-disable-next-line no-await-in-loop
await removeFromQueue(user.value);
}
} }
}; };
}; };