Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: removing duplicate session rerolling code (as it is in passport@^0.6 now)

Browse Source
This commit is contained in:
Julian Lam
2022-08-19 12:52:24 -04:00
parent 20ebf0a1e0
commit 65b3996ac6
1 changed files with 1 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/controllers/authentication.js
View File

@@ -339,19 +339,7 @@ authenticationController.doLogin = async function (req, uid) {
return;
}
const loginAsync = util.promisify(req.login).bind(req);
const { reroll } = req.res.locals;
if (reroll !== false) {
const regenerateSession = util.promisify(req.session.regenerate).bind(req.session);
const sessionData = { ...req.session };
await regenerateSession();
for (const [prop, value] of Object.entries(sessionData)) {
req.session[prop] = value;
}
}
await loginAsync({ uid: uid }, { keepSessionInfo: true });
await loginAsync({ uid: uid }, { keepSessionInfo: req.res.locals !== false });
await authenticationController.onSuccessfulLogin(req, uid);
};