Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-08 15:05:46 +01:00
Code Issues Packages Projects Releases Wiki Activity

check nid before pusing and marking read

Browse Source
This commit is contained in:
barisusakli
2014-09-23 16:02:19 -04:00
parent a0da73dabd
commit 64c51d5cba
2 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/notifications.js
View File

@@ -120,6 +120,11 @@ var async = require('async'),
Notifications.push = function(notification, uids, callback) { Notifications.push = function(notification, uids, callback) {
callback = callback || function() {}; callback = callback || function() {};
if (!notification.nid) {
return callback();
}
var websockets = require('./socket.io'); var websockets = require('./socket.io');
if (!Array.isArray(uids)) { if (!Array.isArray(uids)) {
uids = [uids]; uids = [uids];
@@ -183,7 +188,7 @@ var async = require('async'),
return callback(); return callback();
} }
var notificationKeys = nids.map(function(nid) { var notificationKeys = nids.filter(Boolean).map(function(nid) {
return 'notifications:' + nid; return 'notifications:' + nid;
}); });

4
src/user/notifications.js
View File

@@ -71,9 +71,7 @@ var async = require('async'),
winston.info('[notifications.get] nid ' + nids[index] + ' not found. Removing.'); winston.info('[notifications.get] nid ' + nids[index] + ' not found. Removing.');
} }
if (nids[index]) { deletedNids.push(nids[index]);
deletedNids.push(nids[index]);
}
} }
}); });