Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-31 02:55:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: let recent replies respect oldest/newest sort settings

Browse Source
This commit is contained in:
psychobunny
2021-04-11 19:53:40 -04:00
parent 0f249aa729
commit 60eed8d89f
2 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
public/src/client/topic/replies.js
View File

@@ -66,7 +66,11 @@ define('forum/topic/replies', ['navigator', 'components', 'forum/topic/posts'],
app.parseAndTranslate('topic', 'posts', data, function (html) { app.parseAndTranslate('topic', 'posts', data, function (html) {
var replies = $('[component="post"][data-pid="' + post.toPid + '"] [component="post/replies"]').first(); var replies = $('[component="post"][data-pid="' + post.toPid + '"] [component="post/replies"]').first();
if (replies.length) { if (replies.length) {
if (config.topicPostSort === 'newest_to_oldest') {
replies.prepend(html);
} else {
replies.append(html); replies.append(html);
}
posts.onNewPostsAddedToDom(html); posts.onNewPostsAddedToDom(html);
} }
}); });

4
src/socket.io/posts.js
View File

@@ -116,8 +116,8 @@ SocketPosts.getReplies = async function (socket, pid) {
if (!utils.isNumber(pid)) { if (!utils.isNumber(pid)) {
throw new Error('[[error:invalid-data]]'); throw new Error('[[error:invalid-data]]');
} }
const { topicPostSort } = await user.getSettings(socket.uid);
const pids = await posts.getPidsFromSet(`pid:${pid}:replies`, 0, -1, false); const pids = await posts.getPidsFromSet(`pid:${pid}:replies`, 0, -1, topicPostSort === 'newest_to_oldest');
let [postData, postPrivileges] = await Promise.all([ let [postData, postPrivileges] = await Promise.all([
posts.getPostsByPids(pids, socket.uid), posts.getPostsByPids(pids, socket.uid),