fix: #7038, autoLocale logic not playing nicely with no-refresh auths (#7059)

* fix: #7038, autoLocale logic not playing nicely with no-refresh auths

- on login, req.query.lang is deleted (since it seems to be left over)
- on logout, the middleware.autoLocale is executed, which resets
  req.query.lang
- middleware.autoLocale is new, just refactored existing logic in
  webserver.js into new middleware method.

* style: tests, use lodash

* fix: timeago strings not switching languages on login or out

public/src/app.js

@@ -140,7 +140,7 @@ app.cacheBuster = null;
 				Notifications.prepareDOM();
 				Chat.prepareDOM();
 				app.reskin(data.config.bootswatchSkin);
-				callback();
+				translator.switchTimeagoLanguage(callback);
 			});
 		});
 	};

public/src/modules/translator.js

@@ -596,6 +596,15 @@
 				toggle();
 			}
 		},
+
+		switchTimeagoLanguage: function switchTimeagoLanguage(callback) {
+			// Delete the cached shorthand strings if present
+			delete adaptor.timeagoShort;
+
+			var languageCode = utils.userLangToTimeagoCode(config.userLang);
+			jQuery.getScript(config.relative_path + '/assets/vendor/jquery/timeago/locales/jquery.timeago.' + languageCode + '.js').done(callback);
+		},
+
 		prepareDOM: function prepareDOM() {
 			// Add directional code if necessary
 			adaptor.translate('[[language:dir]]', function (value) {

src/controllers/authentication.js

@@ -284,6 +284,8 @@ function continueLogin(req, res, next) {
 				});
 			});
 		} else {
+			delete req.query.lang;
+
 			async.parallel({
 				doLogin: async.apply(authenticationController.doLogin, req, userData.uid),
 				header: async.apply(middleware.generateHeader, req, res, {}),

src/middleware/headers.js

@@ -2,8 +2,10 @@
 
 var os = require('os');
 var winston = require('winston');
+var _ = require('lodash');
 
 var meta = require('../meta');
+var languages = require('../languages');
 
 module.exports = function (middleware) {
 	middleware.addHeaders = function (req, res, next) {
@@ -60,4 +62,30 @@ module.exports = function (middleware) {
 
 		next();
 	};
+
+	let langs = [];
+	middleware.autoLocale = function (req, res, next) {
+		if (parseInt(req.uid, 10) > 0 || !meta.config.autoDetectLang) {
+			return next();
+		}
+
+		var lang = req.acceptsLanguages(langs);
+		if (!lang) {
+			return next();
+		}
+		req.query.lang = lang;
+		next();
+	};
+
+	languages.listCodes(function (err, codes) {
+		if (err) {
+			winston.error('[middleware/autoLocale] Could not retrieve languages codes list!');
+			codes = [];
+		}
+
+		winston.verbose('[middleware/autoLocale] Retrieves languages list for middleware');
+		var defaultLang = meta.config.defaultLang || 'en-GB';
+
+		langs = _.uniq([defaultLang, ...codes]);
+	});
 };

src/webserver.js

@@ -25,7 +25,6 @@ var db = require('./database');
 var file = require('./file');
 var emailer = require('./emailer');
 var meta = require('./meta');
-var languages = require('./languages');
 var logger = require('./logger');
 var plugins = require('./plugins');
 var flags = require('./flags');
@@ -194,12 +193,13 @@ function setupExpressApp(app, callback) {
 	app.use(middleware.addHeaders);
 	app.use(middleware.processRender);
 	auth.initialize(app, middleware);
+	app.use(middleware.autoLocale);	// must be added after auth middlewares are added
 
 	var toobusy = require('toobusy-js');
 	toobusy.maxLag(meta.config.eventLoopLagThreshold);
 	toobusy.interval(meta.config.eventLoopInterval);
 
-	setupAutoLocale(app, callback);
+	callback();
 }
 
 function setupFavicon(app) {
@@ -233,35 +233,6 @@ function setupCookie() {
 	return cookie;
 }
 
-function setupAutoLocale(app, callback) {
-	languages.listCodes(function (err, codes) {
-		if (err) {
-			return callback(err);
-		}
-
-		var defaultLang = meta.config.defaultLang || 'en-GB';
-
-		var langs = [defaultLang].concat(codes).filter(function (el, i, arr) {
-			return arr.indexOf(el) === i;
-		});
-
-		app.use(function (req, res, next) {
-			if (parseInt(req.uid, 10) > 0 || !meta.config.autoDetectLang) {
-				return next();
-			}
-
-			var lang = req.acceptsLanguages(langs);
-			if (!lang) {
-				return next();
-			}
-			req.query.lang = lang;
-			next();
-		});
-
-		callback();
-	});
-}
-
 function listen(callback) {
 	callback = callback || function () { };
 	var port = nconf.get('port');

test/locale-detect.js

@@ -9,19 +9,22 @@ var meta = require('../src/meta');
 
 describe('Language detection', function () {
 	it('should detect the language for a guest', function (done) {
-		meta.config.autoDetectLang = 1;
+		meta.configs.set('autoDetectLang', 1, function (err) {
+			assert.ifError(err);
 			request(nconf.get('url') + '/api/config', {
 				headers: {
 					'Accept-Language': 'de-DE,de;q=0.5',
 				},
+				json: true,
 			}, function (err, res, body) {
 				assert.ifError(err);
 				assert.ok(body);
 
-			assert.strictEqual(JSON.parse(body).userLang, 'de');
+				assert.strictEqual(body.userLang, 'de');
 				done();
 			});
 		});
+	});
 
 	it('should do nothing when disabled', function (done) {
 		meta.configs.set('autoDetectLang', 0, function (err) {
@@ -30,11 +33,12 @@ describe('Language detection', function () {
 				headers: {
 					'Accept-Language': 'de-DE,de;q=0.5',
 				},
+				json: true,
 			}, function (err, res, body) {
 				assert.ifError(err);
 				assert.ok(body);
 
-				assert.strictEqual(JSON.parse(body).userLang, 'en-GB');
+				assert.strictEqual(body.userLang, 'en-GB');
 				done();
 			});
 		});