Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-29 10:06:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: use single function for api code

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2020-10-15 12:12:01 -04:00
parent 25e4a09816
commit 5e2caf19f5
6 changed files with 60 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/socket.io/groups.js
View File

@@ -7,7 +7,7 @@ const user = require('../user');
const utils = require('../utils');
const slugify = require('../slugify');
const events = require('../events');
const privileges = require('../privileges');
const api = require('../api');
const notifications = require('../notifications');
const sockets = require('.');
@@ -284,24 +284,7 @@ SocketGroups.kick = async (socket, data) => {
SocketGroups.create = async (socket, data) => {
sockets.warnDeprecated(socket, 'POST /api/v3/groups');
if (!socket.uid) {
throw new Error('[[error:no-privileges]]');
} else if (typeof data.name !== 'string' || groups.isPrivilegeGroup(data.name)) {
throw new Error('[[error:invalid-group-name]]');
}
const canCreate = await privileges.global.can('group:create', socket.uid);
if (!canCreate) {
throw new Error('[[error:no-privileges]]');
}
data.ownerUid = socket.uid;
data.system = false;
const groupData = await groups.create(data);
logGroupEvent(socket, 'group-create', {
groupName: data.name,
});
const groupData = await api.groups.create(socket, data);
return groupData;
};